Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1894 workflow item close fix #2086

Merged
merged 2 commits into from
Nov 6, 2024
Merged

1894 workflow item close fix #2086

merged 2 commits into from
Nov 6, 2024

Conversation

MartinJurcoGlina
Copy link
Collaborator

@MartinJurcoGlina MartinJurcoGlina commented Nov 5, 2024

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

  • fixed bug in provisioning that broke workflow item data structure, preventing it from being closed (exchangeRate was missing after WF update in provisioning - it is required property if WF budget is set)

How to test

  1. run app, log in as jxavier
  2. Open Amazonas Fund > Furniture (this is where the bug could be reproduced)
  3. closing every WF item should work now, should also work everywhere else

Closes #1894

Copy link

github-actions bot commented Nov 5, 2024

Warnings
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against ebf41c5

@openkfwCI
Copy link

openkfwCI commented Nov 5, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 60742 on remote server succeededTue, 05 Nov 2024 17:36:07 +0000

Generated by E2E-Test

@SamuelPull SamuelPull merged commit 650331f into main Nov 6, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some workflowitems cannot be closed due to error
3 participants