Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1900 Additional metadata in WF documents #1952

Merged
merged 13 commits into from
Sep 20, 2024
Merged

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Aug 23, 2024

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. Run full TB (test both minio and azure storage)
  2. Create a WF item, add a file with comment
  3. Edit an existing WF item, add a file with comment
  4. Workflow item details screen > Documents (ℹ️ or 📎 icon) contains comment and correct date and time

Closes #1900

Copy link

github-actions bot commented Aug 23, 2024

Warnings
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against 041f910

@openkfwCI
Copy link

openkfwCI commented Aug 23, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 60385 on remote server failedThu, 19 Sep 2024 11:45:27 +0000

Generated by E2E-Test

@SamuelPull SamuelPull changed the title draft: 1900 docs metadata DRAFT: 1900 docs metadata Aug 23, 2024
@SamuelPull SamuelPull changed the title DRAFT: 1900 docs metadata #1900 Additional metadata in WF documents Aug 27, 2024
@MartinJurcoGlina MartinJurcoGlina self-assigned this Sep 10, 2024
Copy link
Collaborator

@MartinJurcoGlina MartinJurcoGlina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document added via external link should probably have an option of comment as well. Other thing is that for external link documents the date column shows "Invalid Date".

@SamuelPull SamuelPull linked an issue Sep 19, 2024 that may be closed by this pull request
1 task
@MartinJurcoGlina MartinJurcoGlina merged commit 97ce29d into main Sep 20, 2024
30 checks passed
@MartinJurcoGlina MartinJurcoGlina deleted the 1900-docs-metadata branch September 20, 2024 12:04
@SamuelPull SamuelPull linked an issue Sep 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants