Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close (sub)project warning message #1880

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Close (sub)project warning message #1880

merged 2 commits into from
Jul 4, 2024

Conversation

galethil
Copy link
Collaborator

@galethil galethil commented Jun 17, 2024

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. Create new project and subproject
  2. Close subproject
  3. Close project
  4. In both cases you should see the warning in all languages

Closes #1871

Copy link

github-actions bot commented Jun 17, 2024

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against b77df20

@openkfwCI
Copy link

openkfwCI commented Jun 17, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 59772 on remote server succeededWed, 03 Jul 2024 09:26:21 +0000

Generated by E2E-Test

@galethil galethil merged commit 1c3f645 into main Jul 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display warning message when closing a project
3 participants