Describe approach to error handling and fix NotAuthorized HTTP status code #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbader
force-pushed
the
131-error-handling
branch
3 times, most recently
from
c6adeef
to
9399e25
Compare
kevinbader
force-pushed
the
131-error-handling
branch
from
9399e25
to
82d2780
Compare
kevinbader
force-pushed
the
131-error-handling
branch
from
82d2780
to
417e06c
Compare
Stezido
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Nice approach. Let's use following Error-Codes:
- 400 Bad Request: The request cannot be fulfilled due to bad syntax.
- 401 Unauthorized: Error code response for missing or invalid authentication token.
- 403 Forbidden: Error code for user not authorized to perform the operation or the resource is unavailable for some reason, but authentication token is OK.
- 409 Conflict: Whenever a resource conflict would be caused by fulfilling the request. Duplicate entries is an example cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lays out the path for #131 but more work needs to be done in a later PR.