Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update nginx to allow new exchange rate url #1411

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

SamuelPull
Copy link
Collaborator

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Url for exchange rate API changed. For production build, nginx configuration needs to be updated. We also want to make it configurable with with environment variables.
When REACT_APP_EXCHANGE_RATE_URL is set, nginx is automatically updated with this value during build time.

Closes #1405

@openkfwCI
Copy link

openkfwCI commented Jul 6, 2023

NotesTime
Note for Reviewer: E2E tests on remote server failedThu, 06 Jul 2023 13:01:18 +0000

Generated by E2E-Test

@georgimld georgimld merged commit b3bd460 into main Jul 6, 2023
@georgimld georgimld deleted the 1405-nginx-config branch July 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics page not working because of failed request to currency API
3 participants