Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: update URL for fetching exchange rates #1406

Merged
merged 1 commit into from
Jul 6, 2023
Merged

ui: update URL for fetching exchange rates #1406

merged 1 commit into from
Jul 6, 2023

Conversation

georgimld
Copy link
Collaborator

@georgimld georgimld commented Jul 4, 2023 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

  • Updated url for fethcing exchange rates
  • Added option to pass the URL as an env var in the frontend

Closes #1405

@github-actions
Copy link

github-actions bot commented Jul 4, 2023 •
edited
Loading

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against f106fd8

@openkfwCI
Copy link

openkfwCI commented Jul 4, 2023 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededWed, 05 Jul 2023 13:03:18 +0000

Generated by E2E-Test

@georgimld georgimld requested a review from SamuelPull July 5, 2023 14:27
@SamuelPull SamuelPull merged commit 4e76fdd into main Jul 6, 2023
@SamuelPull SamuelPull deleted the 1405-exchange-rate branch July 6, 2023 07:07
@mayrmartin mayrmartin mentioned this pull request Oct 17, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelPull SamuelPull SamuelPull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analytics page not working because of failed request to currency API
3 participants
@georgimld @openkfwCI @SamuelPull