-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TableView component #1247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-arnauer
commented
Jul 27, 2022
Comment on lines
+97
to
+117
const useRawColumns = () => { | ||
const rawColumns = [ | ||
// Documentation: https://react-data-table-component.netlify.app/?path=/docs/api-columns--page | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rawColumns must be returned by a hook/function, otherwise the string object will not be up2date in this object if the language has been changed
Generated by E2E-Test |
daniel-arnauer
force-pushed
the
1226-add-budgets-tableview
branch
from
July 27, 2022 11:37
9e86caf
to
3fa9d19
Compare
daniel-arnauer
force-pushed
the
1226-add-budgets-tableview
branch
2 times, most recently
from
July 28, 2022 09:47
98d7336
to
2f13d4a
Compare
daniel-arnauer
force-pushed
the
1226-add-budgets-tableview
branch
from
August 1, 2022 11:06
2f13d4a
to
d096f53
Compare
daniel-arnauer
force-pushed
the
1226-add-budgets-tableview
branch
from
August 3, 2022 08:04
581e9d7
to
05222fe
Compare
mayrmartin
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Budgets in TableView
Add Checkboxes to conditionally render columns
Fix translations in TableView
Add Button for additional data in TableView
Closes #1227
Closes #1226
Closes #1203