Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TableView component #1247

Merged
merged 7 commits into from
Aug 3, 2022
Merged

Conversation

daniel-arnauer
Copy link
Contributor

@daniel-arnauer daniel-arnauer commented Jul 27, 2022

Add Budgets in TableView
Add Checkboxes to conditionally render columns
Fix translations in TableView
Add Button for additional data in TableView

Closes #1227
Closes #1226
Closes #1203

Comment on lines +97 to +117
const useRawColumns = () => {
const rawColumns = [
// Documentation: https://react-data-table-component.netlify.app/?path=/docs/api-columns--page
{
Copy link
Contributor Author

@daniel-arnauer daniel-arnauer Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rawColumns must be returned by a hook/function, otherwise the string object will not be up2date in this object if the language has been changed

@openkfwCI
Copy link

openkfwCI commented Jul 27, 2022

NotesTime
Note for Reviewer: E2E tests on remote server succeededWed, 03 Aug 2022 08:43:27 +0000

Generated by E2E-Test

@daniel-arnauer daniel-arnauer self-assigned this Jul 27, 2022
@daniel-arnauer daniel-arnauer force-pushed the 1226-add-budgets-tableview branch 2 times, most recently from 98d7336 to 2f13d4a Compare July 28, 2022 09:47
@daniel-arnauer daniel-arnauer removed their assignment Jul 28, 2022
@daniel-arnauer daniel-arnauer merged commit a9cce38 into main Aug 3, 2022
@daniel-arnauer daniel-arnauer deleted the 1226-add-budgets-tableview branch August 3, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants