Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose rework #1231

Merged
merged 12 commits into from
Aug 11, 2022
Merged

docker-compose rework #1231

merged 12 commits into from
Aug 11, 2022

Conversation

Stezido
Copy link
Contributor

@Stezido Stezido commented Jul 15, 2022

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Restructure the docker-compose/script operation part of Trubudget since its not very transparent what acually is deployed via the operation script.
This PR adds detailed docker-compose files per Trubudget service and a detailed documentation how to deal with them.

What is done in this PR?

  • Change node version of bc dockerfile to 16.13.0-slim. It is the latest version which is supported by the package "openid-client" and works with the multichain-feed
  • Introduce npmcheck and a ignore file to the bc folder. It helps checking for unused and outdated npm packages
  • Add .dockerignore files to all TB components
  • Remove all old docker-compose files which are replaced with the new ones in the docker-compose folder
  • Add docker-compose folder with a README.md where usage should be documented

Follow-up Issue (#1263):

  • Add docker-compose files for e2e-tests
  • Add docker-compose files for multi-node setup
  • Add docker-compose files for logging-service

Closes #1262

@Stezido Stezido self-assigned this Jul 15, 2022
@openkfwCI
Copy link

openkfwCI commented Jul 15, 2022

NotesTime
Note for Reviewer: E2E tests on remote server failedThu, 11 Aug 2022 12:24:31 +0000

Generated by E2E-Test

Change CHOKIDAR ARGs to ENVs
Add description for CI_COMMIT_SHA and BUILDTIMESTAMP
Add docker compose docs
service: bc, api, ui, export, storage, provisioning, email
@Stezido Stezido marked this pull request as ready for review August 10, 2022 08:24
@Stezido Stezido requested review from georgimld and removed request for mayrmartin August 11, 2022 09:23
@Stezido Stezido assigned georgimld and unassigned Stezido Aug 11, 2022
@Stezido Stezido merged commit 8b32354 into main Aug 11, 2022
@Stezido Stezido deleted the 1046-docker-compose-rework branch August 11, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create own docker-compose section
3 participants