Skip to content

feat(openshell-cli): add --upload flag support to sandbox create - #2099

Merged
bmahabirbu merged 1 commit into
openkaiden:mainfrom
bmahabirbu:worktree-openshell-skill-injection
Jun 8, 2026
Merged

bmahabirbu merged 1 commit into
openkaiden:mainfrom
bmahabirbu:worktree-openshell-skill-injection

Conversation

@bmahabirbu

@bmahabirbu bmahabirbu commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds uploads field to CreateSandboxOptions for specifying local→remote path mappings
  • OpenshellCli.createSandbox() now generates --upload local:remote flags, enabling skill injection into OpenShell sandboxes
  • Adds tests for single upload, multiple uploads, and upload + command separator ordering

Fixes: #2098

🤖 Generated with Claude Code

@bmahabirbu
bmahabirbu requested a review from a team as a code owner June 8, 2026 18:59
@bmahabirbu
bmahabirbu requested review from MarsKubeX and benoitf and removed request for a team June 8, 2026 18:59
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds optional uploads to CreateSandboxOptions; OpenshellCli.createSandbox emits one --upload <local>:<remote> flag per mapping in order; tests added to verify single/multiple uploads and flag placement before the -- separator.

Changes

Sandbox Upload Configuration

Layer / File(s) Summary
Upload option contract and implementation
packages/api/src/openshell-gateway-info.ts, packages/main/src/plugin/openshell-cli/openshell-cli.ts, packages/main/src/plugin/openshell-cli/openshell-cli.spec.ts
CreateSandboxOptions interface adds an optional uploads field for local-to-remote path mappings. OpenshellCli.createSandbox iterates over uploads to emit --upload <local>:<remote> arguments in order. Test cases validate single and multiple upload argument formatting and verify flag placement before the -- command separator.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • openkaiden/kaiden#2020: The main PR extends the OpenshellCli.createSandbox command wrapper by adding CreateSandboxOptions.uploads support and corresponding --upload argv emission with updated test cases.

Suggested reviewers

  • benoitf
  • gastoner
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, explaining the uploads field addition, CLI flag generation, and test coverage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: adding --upload flag support to the openshell sandbox create command, which aligns with the extension of CreateSandboxOptions and the CLI implementation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmahabirbu bmahabirbu changed the title feat(openshell-cli): add --upload support to sandbox create feat(openshell-cli): add skill injection support via --upload Jun 8, 2026
@bmahabirbu
bmahabirbu force-pushed the worktree-openshell-skill-injection branch from eca1f9c to 8a2fc2e Compare June 8, 2026 19:00
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Adds upload support to CreateSandboxOptions and createSandbox() for
future skill/MCP injection when workspace creation is wired directly
through the openshell CLI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Brian <bmahabir@bu.edu>
@bmahabirbu bmahabirbu changed the title feat(openshell-cli): add skill injection support via --upload feat(openshell-cli): add --upload flag support to sandbox create Jun 8, 2026
@bmahabirbu
bmahabirbu force-pushed the worktree-openshell-skill-injection branch from 8a2fc2e to aa95236 Compare June 8, 2026 19:15
@bmahabirbu
bmahabirbu merged commit e15feb3 into openkaiden:main Jun 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add --upload support for openshell

2 participants