2024-03-05 Meeting notes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyBooth
approved these changes
Mar 6, 2024
ljharb
approved these changes
Mar 6, 2024
styfle
reviewed
Mar 6, 2024
Co-authored-by: Steven <[email protected]>
lukekarrys
reviewed
Mar 6, 2024
| * Presented in [#15](https://github.com/openjs-foundation/package-metadata-interoperability-collab-space/issues/15) | ||
| * @darcylarke has concerns on adding a third field and has given a more verbose explaination in [npm cli #7253](https://github.com/npm/cli/pull/7253#issuecomment-1965846137) | ||
| * @ljharb still feels this should be added regardless of it being a top level field or not, just due to functionality being applied | ||
| * @wes ??? (accurate) |
There was a problem hiding this comment.
Suggested change
| * @wes ??? (accurate) |
This was due to me missing what Wes said but I added it anyway in case someone else was able to fill it in. We should probably just remove this line.
There was a problem hiding this comment.
@wesleytodd do you recall what you had mentioned here?
There was a problem hiding this comment.
Well clearly it was accurate and brilliant 😄
There was a problem hiding this comment.
Very accurate 🤣. No I am not sure what said but I am fine if we just delete.
styfle
reviewed
Mar 7, 2024
Co-authored-by: Steven <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.