Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles in ToC #1379

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Titles in ToC #1379

merged 1 commit into from
Oct 24, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

Partial fix of: #1377

Cool! learned how to use yield and content_for in rails templates.

Screenshot 2024-10-23 at 1 19 19 PM

Should keep page title the same if there is no title provided, and otherwise be {title} - Journal of Open Source Software

Put the page name first because i don't think i'm alone in having my tabs often looking like this

Screenshot 2024-10-23 at 1 20 21 PM

@danielskatz
Copy link
Collaborator

I wonder if these should be "JOSS: {title}"? I kind of like the JOSS ones to be together in my menu/list...

@sneakers-the-rat
Copy link
Contributor Author

we can do whatever we want!

I'm looking at just my tabs right now, and all of them are {page title} - {site title}

Screenshot 2024-10-23 at 1 34 34 PM

So that is the norm, and then the favicon handles the grouping -- maybe your tab hygeine is better than mine ;)

Another thing is SEO, where having the full name in the page title is good (SEO can be a bit of mythology sometimes, so it may not matter that much if it's also in the header metadata), and JOSS: {page title} - Journal of Open Source Software is a little awkward.

but ya not strongly opinionated, just a frequent too-many-tabs-open-haver

@danielskatz
Copy link
Collaborator

I hate to admit this, but I don't use tabs, I use windows, and I choose them from a menu that lists them in alphabetical order...

@sneakers-the-rat
Copy link
Contributor Author

to each their own, but yes ha i think that might be a relatively rare use pattern ;). I don't think four characters would be the end of the world, just a little nonstandard. the SEO question is really the only materially differentiating factor.

Interestingly enough, duckduckgo is filling this in for us even without having a page title:

Screenshot 2024-10-23 at 2 16 48 PM

Copy link
Member

@xuanxu xuanxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@xuanxu xuanxu merged commit 03b4dfa into openjournals:main Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants