-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: PyProBE: Python Processing for Battery Experiments #7294
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Five most similar historical JOSS papers: DiffCapAnalyzer: A Python Package for Quantitative Analysis of Total Differential Capacity Data fuelcell: A Python package and graphical user interface for electrochemical data analysis ProgPy: Python Packages for Prognostics and Health Management of Engineering Systems pyomeca: An Open-Source Framework for Biomechanical Analysis ThermoParser: Streamlined Analysis of Thermoelectric Properties |
Hello @tomjholland, we will use this pre-review issue to find an editor and reviewers, and sort out any issues prior to the review starting. While your submission looks in scope for JOSS and meets most of our requirements, I can't find instructions for running a test suite—at minimum, software needs to be tested (e.g., unit and functional) and have some instructions for manually running tests. Ideally, this would be automated (e.g., with pytest), and at best hooked into continuous integration (e.g., GitHub Actions). |
Hello @kyleniemeyer, my project has a test suite that you should be able to find in
I hope this helps, and let me know if there is anything else you need me to do. |
Submitting author: @tomjholland (Thomas Holland)
Repository: https://github.com/ImperialCollegeLondon/PyProBE
Branch with paper.md (empty if default branch):
Version: 1.0.2
Editor: Pending
Reviewers: Pending
Managing EiC: Kyle Niemeyer
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @tomjholland. Currently, there isn't a JOSS editor assigned to your paper.
@tomjholland if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: