-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DiffCapAnalyzer: A Python Package for Quantitative Analysis of Total Differential Capacity Data #2624
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @yangbai90 it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Hi @WardLT, you asked in the 'pre-review' thread how to get started. I have added a checklist to the top of this issues under your name...you now just check off the boxes, and give the author(s) of the package any tips on how to improve their code for any of the boxes that are not 'check-worthy'. |
Thanks! |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
OK, @WardLT is now a reviewer |
OK, @WardLT is now a reviewer |
@whedon assign @yangbai90 as reviewer |
Thanks @jgostick I updated the paper with everyone's ORCIDs, made a release of the software |
@whedon set 10.5281/zenodo.4089118 as archive |
OK. 10.5281/zenodo.4089118 is the archive. |
@whedon generate pdf |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1817 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1817, then you can now move forward with accepting the submission by compiling again with the flag
|
👋 @nicolet5 - this basically looks ready to go, but I have some questions about cases in the references. I feel like Gaussian and Lorentzian should be capitalized, for example. And lifepo4 doesn't seem correct either. Can you fix these, by protecting the capital letters with {}s in the bib file, along with anything else similar that I didn't catch? Then we can proceed to accept this submission |
@danielskatz Thank you for pointing that out, I've fixed those two references and checked the others for similar issues. They should all be good to go now! |
@whedon accept |
|
@whedon accept (trying again) |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1824 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1824, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @nicolet5 (Nicole Thompson) and co-authors!! And thanks to @yangbai90 & @WardLT for reviewing, and @jgostick for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @nicolet5 (Nicole Thompson)
Repository: https://github.com/nicolet5/DiffCapAnalyzer
Version: v0.1.1
Editor: @jgostick
Reviewers: @yangbai90, @WardLT
Archive: 10.5281/zenodo.4089118
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@yangbai90, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jgostick know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @yangbai90
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @WardLT
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: