Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: H-RISK with NoiseModelling: a QGIS plugin to predict environmental noise and estimate health risks #6023

Closed
editorialbot opened this issue Nov 6, 2023 · 96 comments
Assignees
Labels
accepted Batchfile Inno Setup published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Shell Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 6, 2023

Submitting author: @jtagusari (Junta Tagusari)
Repository: https://gitlab.com/jtagusari/hrisk-noisemodelling
Branch with paper.md (empty if default branch): joss
Version: v0.2.0
Editor: @crvernon
Reviewers: @kanishkan91, @praneethd7
Archive: 10.5281/zenodo.10473207

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7f02080c5ba51687d4aefb37b4b290a1"><img src="https://joss.theoj.org/papers/7f02080c5ba51687d4aefb37b4b290a1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7f02080c5ba51687d4aefb37b4b290a1/status.svg)](https://joss.theoj.org/papers/7f02080c5ba51687d4aefb37b4b290a1)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@kanishkan91, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @praneethd7

📝 Checklist for @kanishkan91

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.34 s (187.2 files/s, 349910.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            11              0              0         107342
Python                          34            763            582           5221
Qt Linguist                      1              0              0           1373
Groovy                           7            115             46           1197
Markdown                         3            199              0            547
Bourne Shell                     1             21             21            112
TeX                              1              7              0             76
DOS Batch                        1             19              2             63
Qt Project                       1              0              0             27
XML                              2              0              0             22
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            63           1125            655         115998
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 854

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2800/686249 is OK
- 10.1265/jjh.19014 is OK
- 10.2788/32029 is OK
- 10.3390/ijgi8030130 is OK
- 10.1016/j.apacoust.2021.107987 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@crvernon
Copy link

crvernon commented Nov 6, 2023

Alright @jtagusari and @kanishkan91 - This is the review thread for the paper. All of our communications will happen here from now on.

Please read the "Reviewer instructions & questions" in the first comment above.

Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #6023 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.

Don't hesitate to reach out if you have any questions!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jtagusari
Copy link

Thank you very much @crvernon, and I appreciate @kanishkan91 for agreeing to review the manuscript.
I would like to ask 1 question: Is it possible to update the repository right now (before undergoing reviewing the scripts)? Since the core calculation module (NoiseModelling) has been updated, some bugs have been fixed and some trivial features have been added, I would like to replace the scripts with the updated version. The main functionalities are unchanged and revision of the manuscript will not be needed. It would be great if I could do this. Please let me know if it is possible.

Thanks.

@crvernon
Copy link

crvernon commented Nov 7, 2023

Sure @jtagusari that is no problem at all; just let us know when you are ready. @kanishkan91 let's hold off until we get the green light to proceed.

@jtagusari
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @jtagusari, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@jtagusari
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.42 s (218.1 files/s, 302921.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            27              0              0         113389
Python                          46           1174            688           7445
Qt Linguist                      1              0              0           2391
Groovy                           7            124             47           1296
Markdown                         4            250              0            552
Bourne Shell                     1             21             21            112
TeX                              1              7              0             76
DOS Batch                        1             19              2             54
Qt Project                       1              0              0             40
XML                              2              0              0             22
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            92           1596            762         125395
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 854

@jtagusari
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jtagusari
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.42 s (219.4 files/s, 304652.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            27              0              0         113389
Python                          46           1174            688           7445
Qt Linguist                      1              0              0           2391
Groovy                           7            124             47           1296
Markdown                         4            251              0            555
Bourne Shell                     1             21             21            112
TeX                              1              7              0             76
DOS Batch                        1             19              2             54
Qt Project                       1              0              0             40
XML                              2              0              0             22
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            92           1597            762         125398
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 943

@jtagusari
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jtagusari
Copy link

Thank you @crvernon for waiting.
The repository was updated (and slight changes were made on the paper).
I would like you to start reviewing the project.

Thanks

@crvernon
Copy link

@kanishkan91 you can now review this when you are ready. Thanks!

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2800/686249 is OK
- 10.1007/s10661-023-11268-9 is OK
- 10.1265/jjh.19014 is OK
- 10.2788/32029 is OK
- 10.3390/ijgi8030130 is OK
- 10.1016/j.apacoust.2021.107987 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4906, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Jan 14, 2024
@crvernon
Copy link

👋 @jtagusari

I will be unavailable from Jan. 17-29. An EiC will make the final pass on this shortly so you should be good to go from here. I will check in when I come back to make sure everything is OK if you don't already have a published paper by then!

Thanks!

@jtagusari
Copy link

@crvernon

Thank you for your support from the submission of the paper to this point.
I await the completion of the checks by EiC and will rely on you if there are any problems.

Thanks

@kthyng
Copy link

kthyng commented Jan 19, 2024

Here are my steps to finalize the publication!

  • Check that version was updated
  • Check that software archive exists, has been input to JOSS, and title and author list look good
  • Check paper

@kthyng
Copy link

kthyng commented Jan 19, 2024

@jtagusari Regarding your paper, please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file. "Europe" is spelled with a lowercase "e" in several references.

@jtagusari
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Jan 22, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Jan 22, 2024

@jtagusari did you make any changes? The words are still lowercase.

@jtagusari
Copy link

@kthyng
Sorry for the confusion. After checking the pdf I wanted to fix the bib file but could not see it (not sure why). Anyway, I have corrected the bib file and push it to the branch. Could you please check if it is corrected?
Thanks.

@kthyng
Copy link

kthyng commented Jan 23, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Jan 23, 2024

Ok looks good to go!

@kthyng
Copy link

kthyng commented Jan 23, 2024

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Tagusari
  given-names: Junta
  orcid: "https://orcid.org/0000-0002-3321-4473"
doi: 10.5281/zenodo.10473207
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Tagusari
    given-names: Junta
    orcid: "https://orcid.org/0000-0002-3321-4473"
  date-published: 2024-01-23
  doi: 10.21105/joss.06023
  issn: 2475-9066
  issue: 93
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6023
  title: "H-RISK with NoiseModelling: a QGIS plugin to predict
    environmental noise and estimate health risks"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06023"
  volume: 9
title: "H-RISK with NoiseModelling: a QGIS plugin to predict
  environmental noise and estimate health risks"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.06023 joss-papers#4944
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06023
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Jan 23, 2024
@kthyng
Copy link

kthyng commented Jan 23, 2024

Congrats on your new publication @jtagusari! Many thanks to editor @crvernon and reviewers @kanishkan91 and @praneethd7 for your time, hard work, and expertise!!

@kthyng kthyng closed this as completed Jan 23, 2024
@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06023/status.svg)](https://doi.org/10.21105/joss.06023)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06023">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06023/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06023/status.svg
   :target: https://doi.org/10.21105/joss.06023

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@jtagusari
Copy link

Many thanks to @crvernon , @kanishkan91 , @praneethd7 and @kthyng !
It has been a great time to review and improve my work! I will continue to develop our community.

@kthyng
Copy link

kthyng commented Jan 24, 2024

@jtagusari If you're interested in reviewing in the future, please sign up here: https://reviewers.joss.theoj.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Batchfile Inno Setup published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Shell Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Development

No branches or pull requests

6 participants