-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: A Python Tool for Predicting and Assessing Unconventional Rare-Earth and Critical Mineral Resources #5500
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Checking the BibTeX entries failed with the following error:
|
|
Wordcount for |
@jeinsle and @jameshgrn thanks for agreeing to review this submission. This is the "official" review issue, instructions for creating your reviewer checklist and conducting the review should be in the top comment of this issue, but please do not hesitate to reach out to me with any questions or to ask for any clarification. Ideally we'd like to ask that you complete your reviews within 6 weeks, and I will set up reminder so the bot prods us all in 3 weeks. Thanks, |
@editorialbot remind @jeinsle in three weeks |
Reminder set for @jeinsle in three weeks |
@editorialbot remind @jameshgrn in three weeks |
Reminder set for @jameshgrn in three weeks |
Review checklist for @jeinsleConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@jeinsle per your comment in the pre-review issue:
Would you and Francesco prefer that he be added as a separate reviewer? |
for him it may be better for profile to be separate, but not clear how you want to handle.
…----------------------------------------------------------------------------------------------------
Sometimes I work outside of standard hours, but I do not expect replies during these times.
Joshua F. Einsle
Lord Kelvin Adam Smith Research Fellow in Data Science
School of Geographical and Earth Sciences
University of Glasgow
https://www.gla.ac.uk/schools/ges/staff/joshuafranzeinsle/
________________________________
From: J. Hariharan ***@***.***>
Sent: Tuesday, May 30, 2023 4:05 PM
To: openjournals/joss-reviews ***@***.***>
Cc: Joshua Franz Einsle ***@***.***>; Mention ***@***.***>
Subject: Re: [openjournals/joss-reviews] [REVIEW]: A Python Tool for Predicting and Assessing Unconventional Rare-Earth and Critical Mineral Resources (Issue #5500)
@jeinsle<https://github.com/jeinsle> per your comment in the pre-review issue:
Hi Jay
as noted my post-doc Francesco Perrone will be helping on my end. His GitHub info is: FrancescoPerrone
We will get started on the checklist from tomorrow.
Cheers
josh
Would you and Francesco prefer that he be added as a separate reviewer?
—
Reply to this email directly, view it on GitHub<#5500 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADVMCUZXN5N2JMULCLVMVBLXIYEDDANCNFSM6AAAAAAYT6NQU4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@FrancescoPerrone I've added you to the list of reviewers so you should be able to generate your own review checklist and fill it out / edit it. Please let me know if this does not work properly. |
Hi there, apologies for not getting back sooner than now. I’m just acknowledging your email; I’ll be in touch if any additional question/help will be required.
Thanks a lot!
With kind regards,
Francesco
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: J. Hariharan ***@***.***>
Sent: Tuesday, May 30, 2023 4:15:15 PM
To: openjournals/joss-reviews ***@***.***>
Cc: Francesco Perrone ***@***.***>; Mention ***@***.***>
Subject: Re: [openjournals/joss-reviews] [REVIEW]: A Python Tool for Predicting and Assessing Unconventional Rare-Earth and Critical Mineral Resources (Issue #5500)
@FrancescoPerrone<https://github.com/FrancescoPerrone> I've added you to the list of reviewers so you should be able to generate your own review checklist and fill it out / edit it. Please let me know if this does not work properly.
—
Reply to this email directly, view it on GitHub<#5500 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALXCV7JCDEQWLSOPYN6CZDXIYFIHANCNFSM6AAAAAAYT6NQU4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@editorialbot generate my checklist
…----------------------------------------------------------------------------------------------------
Sometimes I work outside of standard hours, but I do not expect replies during these times.
Joshua F. Einsle
Lord Kelvin Adam Smith Research Fellow in Data Science
School of Geographical and Earth Sciences
University of Glasgow
https://www.gla.ac.uk/schools/ges/staff/joshuafranzeinsle/
________________________________
From: The Open Journals editorial robot ***@***.***>
Sent: Tuesday, May 30, 2023 1:39 PM
To: openjournals/joss-reviews ***@***.***>
Cc: Joshua Franz Einsle ***@***.***>; Mention ***@***.***>
Subject: [openjournals/joss-reviews] [REVIEW]: A Python Tool for Predicting and Assessing Unconventional Rare-Earth and Critical Mineral Resources (Issue #5500)
Submitting author: @justaPCWingo<https://github.com/justaPCWingo> (Patrick Wingo<http://orcid.org/0000-0003-3934-7733>)
Repository: https://github.com/NETL-RIC/URC-Assessment-Method
Branch with paper.md (empty if default branch): joss-submit
Version: v1.0.0
Editor: @elbeejay<https://github.com/elbeejay>
Reviewers: @jeinsle<https://github.com/jeinsle>, @jameshgrn<https://github.com/jameshgrn>
Archive: Pending
Status
[status]<https://joss.theoj.org/papers/08aaa53d1f620dec132d7ef5807af16c>
Status badge code:
HTML: <a href="https://joss.theoj.org/papers/08aaa53d1f620dec132d7ef5807af16c"><img src="https://joss.theoj.org/papers/08aaa53d1f620dec132d7ef5807af16c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/08aaa53d1f620dec132d7ef5807af16c/status.svg)](https://joss.theoj.org/papers/08aaa53d1f620dec132d7ef5807af16c)
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository<https://github.com/NETL-RIC/URC-Assessment-Method> and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jeinsle<https://github.com/jeinsle> & @jameshgrn<https://github.com/jameshgrn>, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
@editorialbot generate my checklist
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @elbeejay<https://github.com/elbeejay> know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
@jeinsle<https://github.com/jeinsle>, please create your checklist typing: @editorialbot generate my checklist
@jameshgrn<https://github.com/jameshgrn>, please create your checklist typing: @editorialbot generate my checklist
—
Reply to this email directly, view it on GitHub<#5500>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADVMCU26FQIDBPTRQNDTHJ3XIXS7FANCNFSM6AAAAAAYT6NQU4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@editorialbot generate my checklist |
@jameshgrn I don't know what happened there, maybe the bot was down for a bit. I'd say try once more to get it to generate checklist, and if that is unsuccessful we can find you the raw markdown to create a comment with your reviewer checklist manually. Thanks! |
Review checklist for @FrancescoPerroneConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @jameshgrnConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Adding my thoughts in here. I agree with everything @FrancescoPerrone said so consider that a +1 for their recommendations. I think this is certainly a package that meets JOSS standards of content and substantial effort, but there are several changes to the repository that need to happen before it meets FAIR standards. I tried to solve a conda environment for this package this morning and gave up after a little while of no success. Once an environment management system is implemented (requirements.txt or preferably an environment.yml file for conda) I will test out the package. below are some comments for the repository in general and the paper itself. REPOSITORY COMMENTS
PAPER COMMENTS
|
@editorialbot check references |
|
This sounds good, let me know when you've been able to do this @justaPCWingo - thanks for being understanding and flexible. |
Hi @elbeejay , the tagged version is v1.0.1. Please let me know if there is anything else you need me to do. |
Sounds like you all went with Zenodo, let me know if you still have questions. |
@editorialbot set v1.0.1 |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot set v1.0.1 as version |
Done! version is now v1.0.1 |
@editorialbot set 10.5281/zenodo.8319843 as archive |
Done! archive is now 10.5281/zenodo.8319843 |
@editorialbot recommend-accept |
|
|
Nothing else you have to do @justaPCWingo - thanks! |
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4538, then you can now move forward with accepting the submission by compiling again with the command |
Ok next steps on my end:
|
Looks great! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @justaPCWingo!! Many thanks to editor @elbeejay and reviewers @jeinsle, @jameshgrn, and @FrancescoPerrone for your time, hard work, and expertise!! (I will close this issue once the DOI resolves) |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @justaPCWingo (Patrick Wingo)
Repository: https://github.com/NETL-RIC/URC-Assessment-Method
Branch with paper.md (empty if default branch): joss-submit
Version: v1.0.1
Editor: @elbeejay
Reviewers: @jeinsle, @jameshgrn, @FrancescoPerrone
Archive: 10.5281/zenodo.8319843
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jeinsle & @jameshgrn, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @elbeejay know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jeinsle
📝 Checklist for @FrancescoPerrone
📝 Checklist for @jameshgrn
The text was updated successfully, but these errors were encountered: