Skip to content

Conversation

@galderz
Copy link
Contributor

@galderz galderz commented Nov 19, 2025

Trivial cleanup to move tests out of a test class whose description does not match these tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371792: Refactor barrier loop tests out of TestIfMinMax (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28385/head:pull/28385
$ git checkout pull/28385

Update a local copy of the PR:
$ git checkout pull/28385
$ git pull https://git.openjdk.org/jdk.git pull/28385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28385

View PR using the GUI difftool:
$ git pr show -t 28385

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28385.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2025

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@galderz The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2025

Webrevs

Copy link
Contributor

@benoitmaillard benoitmaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for making the change @galderz!

I have also submitted internal testing just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants