8372135: clang compilation error

[jankratochvil]

clang-20.1.8-4.fc42.x86_64

src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:212:10: error: 'is_containerized' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  212 |     bool is_containerized();
      |          ^       
src/hotspot/os/linux/cgroupSubsystem_linux.hpp:284:18: note: overridden virtual function is here
  284 |     virtual bool is_containerized() = 0;
      |                  ^
In file included from src/hotspot/os/linux/cgroupSubsystem_linux.cpp:27:
src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:214:18: error: 'container_type' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  214 |     const char * container_type() {
      |                  ^
src/hotspot/os/linux/cgroupSubsystem_linux.hpp:288:26: note: overridden virtual function is here
  288 |     virtual const char * container_type() = 0;
      |                          ^
In file included from src/hotspot/os/linux/cgroupSubsystem_linux.cpp:27:
src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:217:54: error: 'memory_controller' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  217 |     CachingCgroupController<CgroupMemoryController>* memory_controller() { return _memory; }
      |                                                      ^
src/hotspot/os/linux/cgroupSubsystem_linux.hpp:289:62: note: overridden virtual function is here
  289 |     virtual CachingCgroupController<CgroupMemoryController>* memory_controller() = 0;
      |                                                              ^
In file included from src/hotspot/os/linux/cgroupSubsystem_linux.cpp:27:
src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:218:51: error: 'cpu_controller' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  218 |     CachingCgroupController<CgroupCpuController>* cpu_controller() { return _cpu; }
      |                                                   ^
src/hotspot/os/linux/cgroupSubsystem_linux.hpp:290:59: note: overridden virtual function is here
  290 |     virtual CachingCgroupController<CgroupCpuController>* cpu_controller() = 0;
      |                                                           ^
In file included from src/hotspot/os/linux/cgroupSubsystem_linux.cpp:27:
src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp:219:30: error: 'cpuacct_controller' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override  219 |     CgroupCpuacctController* cpuacct_controller() { return _cpuacct; }
      |                              ^
src/hotspot/os/linux/cgroupSubsystem_linux.hpp:291:38: note: overridden virtual function is here
  291 |     virtual CgroupCpuacctController* cpuacct_controller() = 0;
      |                                      ^
5 errors generated.                          
gmake[3]: *** [lib/CompileJvm.gmk:180: build/fastdebug-default-clang/hotspot/variant-server/libjvm/objs/cgroupSubsystem_linux.o] Error 1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8372135: clang compilation error

Issue

• JDK-8372135: clang compilation error (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Johan Sjölen (@jdksjolen - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28384/head:pull/28384
$ git checkout pull/28384

Update a local copy of the PR:
$ git checkout pull/28384
$ git pull https://git.openjdk.org/jdk.git pull/28384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28384

View PR using the GUI difftool:
$ git pr show -t 28384

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28384.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372135: clang compilation error

Reviewed-by: stefank, jsjolen, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• f5bc6ee: 8369187: Add wrapper for that forbids use of global allocation and deallocation functions
• 6f1c573: 8371923: Update LockFreeStack for Atomic
• 223cc64: 8343316: Review and update tests using explicit provider names
• ... and 9 more: https://git.openjdk.org/jdk/compare/02ff38f2d7f6abc0e4661e8226bc6780b7a11c3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @jdksjolen, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@jankratochvil The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (639fa862)

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version 639fa86) is now ready to be sponsored by a Committer.

[jdksjolen]

Please wait 24 hours before integrating. This is so that all contributors get a chance to see your PR.

[jankratochvil]

Please wait 24 hours before integrating. This is so that all contributors get a chance to see your PR.

OK for the future, I cannot remove the /integrate so that is for the committer now.

[jdksjolen]

Please wait 24 hours before integrating. This is so that all contributors get a chance to see your PR.

OK for the future, I cannot remove the /integrate so that is for the committer now.

Yup, we'll wait with sponsoring until 24 hours has passed :-).

[kimbarrett]

FWIW, I would have been fine with approving this immediately as trivial and a build blocker.