8370156: Fix jpackage IconTest

[alexeysemenyukoracle]

Rework IconTest.

Verified it produces the output as expected.

It still will not catch JDK-8370155. However, this is deliberate to avoid significant changes in the test and implementation in a single commit.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370156: Fix jpackage IconTest (Bug - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27883/head:pull/27883
$ git checkout pull/27883

Update a local copy of the PR:
$ git checkout pull/27883
$ git pull https://git.openjdk.org/jdk.git pull/27883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27883

View PR using the GUI difftool:
$ git pr show -t 27883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27883.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370156: Fix jpackage IconTest

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• be18e7e: 8064922: [macos] Test javax/swing/JTabbedPane/4624207/bug4624207.java fails
• 0744db8: 8367002: Missing compiled exception handler for "recursive" exception
• 2a8cbd9: 8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE
• ... and 17 more: https://git.openjdk.org/jdk/compare/94c0611b9534f74b41b1f513f5c9ea96f41f83af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8370156
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (9bf7e441)
• 01: Full (112d042f)
• 00: Full (720946df)

[alexeysemenyukoracle]

@sashamatveev PTAL

[alexeysemenyukoracle]

@sashamatveev PTAL

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 3e20a93.
Since your change was applied there have been 20 commits pushed to the master branch:

• be18e7e: 8064922: [macos] Test javax/swing/JTabbedPane/4624207/bug4624207.java fails
• 0744db8: 8367002: Missing compiled exception handler for "recursive" exception
• 2a8cbd9: 8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE
• ... and 17 more: https://git.openjdk.org/jdk/compare/94c0611b9534f74b41b1f513f5c9ea96f41f83af...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 3e20a93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.