8370150: Add StrictMath microbenchmarks to cover FDLIBM algorithms #27881
+672
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back skuksenko! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
Fix copyright format
rgiulietti
reviewed
Oct 20, 2025
| public RangeState(boolean signed, double min, double max) { | ||
| this.min = min; | ||
| this.max = max; | ||
| this.signed = signed; |
There was a problem hiding this comment.
This field is never read.
I guess you want to change the setup() method to use this field rather than rely on nextBoolean()?
|
|
||
| public static class RangeHalfLn2To56Ln2 extends RangeState { | ||
| public RangeHalfLn2To56Ln2() { | ||
| super(0.34657359, 38.8162421); |
There was a problem hiding this comment.
Please consider declaring "magic" values related to ln(2) as private static final doubles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add StrictMath microbenchmarks to cover FDLIBM algorithms
The methods that require fdlibm semantics are sin, cos, tan, asin, acos, atan, exp, log, log10, cbrt, atan2, pow, sinh, cosh, tanh, hypot, expm1, and log1p.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27881/head:pull/27881$ git checkout pull/27881Update a local copy of the PR:
$ git checkout pull/27881$ git pull https://git.openjdk.org/jdk.git pull/27881/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27881View PR using the GUI difftool:
$ git pr show -t 27881Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27881.diff
Using Webrev
Link to Webrev Comment