Skip to content

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Oct 17, 2025

This is a simple fix to add missing call to invalidate_jvmti_stack() to the freeze_epilog(ContinuationWrapper& cont).

Testing:

  • TBD: Run mach5 tiers 1-6

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369609: Continuations preempt_epilog is missing a call to invalidate_jvmti_stack (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27878/head:pull/27878
$ git checkout pull/27878

Update a local copy of the PR:
$ git checkout pull/27878
$ git pull https://git.openjdk.org/jdk.git pull/27878/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27878

View PR using the GUI difftool:
$ git pr show -t 27878

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27878.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2025

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@sspitsyn The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2025

Webrevs

Copy link
Contributor

@pchilano pchilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Serguei.


log_develop_debug(continuations)("=== End of freeze cont ### #" INTPTR_FORMAT, cont.hash());

JVMTI_ONLY(invalidate_jvmti_stack(JavaThread::current()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not directly in preempt_epilog? Is it to cover the freeze fast case too? If that’s the case we should remove the call to invalidate_jvmti_stack from jvmti_yield_cleanup to avoid calling it twice for the freeze slow case. Also I wonder if this call to invalidate_jvmti_stack should just be moved to JvmtiVTMSTransitionDisabler::VTMS_unmount_end instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants