8370123: Minor jpackage refactoring

[alexeysemenyukoracle]

Minor changes, no functional impact.

• ApplicationBuilder: add externalApplication() and mainLauncherClassName() methods
• AppImageSigner.normalizeAppImageLayout() -> AppImageSigner.copyWithUnresolvedAppImageLayout()
• Add JLinkRuntimeBuilder.ensureBaseModuleInModulePath(); move code away from StandardBundlerParam; remove redundant "warning.no.jdk.modules.found" string ID
• Add OverridableResource.probe() method
• Remove dead and "odd" code from IOUtils

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370123: Minor jpackage refactoring (Enhancement - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27873/head:pull/27873
$ git checkout pull/27873

Update a local copy of the PR:
$ git checkout pull/27873
$ git pull https://git.openjdk.org/jdk.git pull/27873/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27873

View PR using the GUI difftool:
$ git pr show -t 27873

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27873.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370123: Minor jpackage refactoring

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• c781a2f: 8370136: Support async execution of jpackage tests
• a1302e5: 8365625: Can't change accelerator colors in Windows L&F
• a1be297: 8369854: (ch) Refine specification of behavior of {Gathering,Writable}ByteChannel.write
• ... and 13 more: https://git.openjdk.org/jdk/compare/eff6439e75d79c67370e79638024296e01101b48...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[alexeysemenyukoracle]

@sashamatveev PTAL

[mlbridge]

Webrevs

• 01: Full (1ef8923f)
• 00: Full (18d4deda)

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 0522cf2.
Since your change was applied there have been 16 commits pushed to the master branch:

• c781a2f: 8370136: Support async execution of jpackage tests
• a1302e5: 8365625: Can't change accelerator colors in Windows L&F
• a1be297: 8369854: (ch) Refine specification of behavior of {Gathering,Writable}ByteChannel.write
• ... and 13 more: https://git.openjdk.org/jdk/compare/eff6439e75d79c67370e79638024296e01101b48...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 0522cf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.