Skip to content

Conversation

nityarai08
Copy link

@nityarai08 nityarai08 commented Oct 17, 2025

Add VM_MEMORY_JAVA tag to mmap calls in os_bsd.cpp for better memory tracking of java process on macOs


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27868/head:pull/27868
$ git checkout pull/27868

Update a local copy of the PR:
$ git checkout pull/27868
$ git pull https://git.openjdk.org/jdk.git pull/27868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27868

View PR using the GUI difftool:
$ git pr show -t 27868

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27868.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2025

Hi @nityarai08, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user nityarai08" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@nityarai08 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@nityarai08 nityarai08 marked this pull request as draft October 17, 2025 17:03
@eastig
Copy link
Member

eastig commented Oct 20, 2025

@eastig
Copy link
Member

eastig commented Oct 20, 2025

@nityarai08 ,

What macOS and Xcode versions are required to support VM_MEMORY_JAVA tag?

OpenJDK macOS recommendation:

It is recommended that you use at least macOS 14 and Xcode 15.4, but earlier versions may also work.

It would be nice to have a gtest.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo, be a good idea to include os/bsd/gc/z/zPhysicalMemoryBacking_bsd.cpp, which has 3 uses that should probably be marked with VM_MEMORY_JAVA. #if defined(APPLE) of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime [email protected] oca Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

3 participants