Skip to content

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Oct 17, 2025

Trivial "inlining" a statically know boolean value to a method.

Test: tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370078: Remove unnecessary argument in ContiguousSpace::initialize (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27865/head:pull/27865
$ git checkout pull/27865

Update a local copy of the PR:
$ git checkout pull/27865
$ git pull https://git.openjdk.org/jdk.git pull/27865/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27865

View PR using the GUI difftool:
$ git pr show -t 27865

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27865.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370078: Remove unnecessary argument in ContiguousSpace::initialize

Reviewed-by: fandreuzzi, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8370078 8370078: Remove unnecessary argument in ContiguousSpace::initialize Oct 17, 2025
@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2025

Webrevs

Copy link
Member

@jsikstro jsikstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2025
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

Going to push as commit a0c4124.
Since your change was applied there have been 43 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2025
@openjdk openjdk bot closed this Oct 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2025
@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@albertnetymk Pushed as commit a0c4124.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the remove-mangle-arg branch October 21, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants