8367989: Remove InstanceKlass::allocate_objArray #27372
Open
+5
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes InstanceKlass::allocate_objArray and has its caller call ObjArrayKlass::allocate_instance directly from oopFactory, like the other array allocations do. See CR for more information why we should have this change. I also removed element_klass_addr() and moved element_klass_offset() to be in a more logical place near element_klass() functions. This upstreams a tiny valhalla diff.
Tested with tier1-4.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27372/head:pull/27372
$ git checkout pull/27372
Update a local copy of the PR:
$ git checkout pull/27372
$ git pull https://git.openjdk.org/jdk.git pull/27372/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27372
View PR using the GUI difftool:
$ git pr show -t 27372
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27372.diff
Using Webrev
Link to Webrev Comment