-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8358731: Remove jdk.internal.access.JavaAWTAccess.java #25677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@dfuch please review this. |
dfuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/integrate |
|
Going to push as commit eb8ee8b.
Your commit was automatically rebased without conflicts. |
The fix for JDK-8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration
removed use of AppContext from java/util/logging/LogManager.java.
That was the only place in the JDK that used jdk.internal.access.JavaAWTAccess.java so it can be removed.
There are 3 tests that use it (digging into internals) but those tests are pointless now that LogManager doesn't use AppContext, so they should be deleted.
Automated client tests and logging tests (JDK tier1 for the latter it seems) all pass.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25677/head:pull/25677$ git checkout pull/25677Update a local copy of the PR:
$ git checkout pull/25677$ git pull https://git.openjdk.org/jdk.git pull/25677/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25677View PR using the GUI difftool:
$ git pr show -t 25677Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25677.diff
Using Webrev
Link to Webrev Comment