8358231: Template interpreter generator crashes with ShouldNotReachHere on some platforms after 8353686

[TheRealMDoerr]

Trivial build fix for PPC64 and s390. Added arm32.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358231: Template interpreter generator crashes with ShouldNotReachHere on some platforms after 8353686 (Bug - P1)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) Review applies to f5df2535
• Aleksey Shipilev (@shipilev - Reviewer)
• Amit Kumar (@offamitkumar - Committer)
• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25568/head:pull/25568
$ git checkout pull/25568

Update a local copy of the PR:
$ git checkout pull/25568
$ git pull https://git.openjdk.org/jdk.git pull/25568/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25568

View PR using the GUI difftool:
$ git pr show -t 25568

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25568.diff

Using Webrev

Link to Webrev Comment

[TheRealMDoerr]

@offamitkumar: Please check on s390.

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358231: Template interpreter generator crashes with ShouldNotReachHere on some platforms after 8353686

Reviewed-by: shade, amitkumar, mbaesken, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 3f59bfd: 8334759: gc/g1/TestMixedGCLiveThreshold.java fails on Windows with JTREG_TEST_THREAD_FACTORY=Virtual due to extra memory allocation
• c5a1543: 8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent
• 90d6ad0: 8356594: JSplitPane loses divider location when reopened via JOptionPane.createDialog()
• ... and 8 more: https://git.openjdk.org/jdk/compare/a3f9e222632d29982ef1463e6c391d5896524705...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (25fb16bf)
• 00: Full (f5df2535)

[vnkozlov]

Good.

[shipilev]

AFAICS with my builds that invoke CDS -Xshare:dump on cross-compiled binaries, ARM32 is failing the same way. I think we need to add a case here:

jdk/src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp

Lines 175 to 179 in c1b5f62

	case Interpreter::java_lang_math_fmaD:
	case Interpreter::java_lang_math_fmaF:
	case Interpreter::java_lang_math_tanh:
	// TODO: Implement intrinsic
	break;

[offamitkumar]

Thanks Martin, for fixing it.

[shipilev]

Looks good, thanks!

[TheRealMDoerr]

Thanks for the reviews!
/integrate

[openjdk]

Going to push as commit 40ce05d.
Since your change was applied there have been 12 commits pushed to the master branch:

• 6418306: 8357944: Remove unused CollectedHeap::is_maximal_no_gc
• 3f59bfd: 8334759: gc/g1/TestMixedGCLiveThreshold.java fails on Windows with JTREG_TEST_THREAD_FACTORY=Virtual due to extra memory allocation
• c5a1543: 8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent
• ... and 9 more: https://git.openjdk.org/jdk/compare/a3f9e222632d29982ef1463e6c391d5896524705...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 40ce05d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[missa-prime]

@eme64 @dholmes-ora This resolves the crash discussed in #24470.

@TheRealMDoerr Thank you for this. I was about to create a PR.