Skip to content

8355372: GenShen: Test gc/shenandoah/generational/TestOldGrowthTriggers.java fails with UseCompactObjectHeaders enabled #24888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
earthling-amzn wants to merge 2 commits into from
Closed

8355372: GenShen: Test gc/shenandoah/generational/TestOldGrowthTriggers.java fails with UseCompactObjectHeaders enabled #24888

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c991cf
Add test case for compact object headers, increase pressure on old ge…
earthling-amzn Apr 25, 2025
70b36ac
Clarify cases with comment
earthling-amzn Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions test/hotspot/jtreg/gc/shenandoah/generational/TestOldGrowthTriggers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,6 @@ public static void makeOldAllocations() {
int replaceIndex = r.nextInt(ArraySize);
int deriveIndex = r.nextInt(ArraySize);
switch (i & 0x3) {
Copy link
Member

@ysramakrishna ysramakrishna Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...otherwise could you just do (i & 0x1) here and change cases 2 & 3 to cases 0 & 1?

case 0:
// 50% chance of creating garbage
array[replaceIndex] = array[replaceIndex].max(array[deriveIndex]);
break;
case 1:
// 50% chance of creating garbage
array[replaceIndex] = array[replaceIndex].min(array[deriveIndex]);
break;
Copy link
Member

@ysramakrishna ysramakrishna Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have left this in place & reduced the heap size of the UseCompactHeaders test to half the current setting to induce the trigger?

case 2:
// creates new old BigInteger, releases old BigInteger,
// may create ephemeral data while computing gcd
Expand Down Expand Up @@ -106,5 +98,17 @@ public static void main(String[] args) throws Exception {
"-XX:ShenandoahGuaranteedYoungGCInterval=0",
"-XX:ShenandoahGuaranteedOldGCInterval=0"
);

testOld("-Xlog:gc",
"-Xms96m",
"-Xmx96m",
"-XX:+UnlockDiagnosticVMOptions",
"-XX:+UnlockExperimentalVMOptions",
"-XX:+UseShenandoahGC",
"-XX:ShenandoahGCMode=generational",
"-XX:ShenandoahGuaranteedYoungGCInterval=0",
"-XX:ShenandoahGuaranteedOldGCInterval=0",
"-XX:+UseCompactObjectHeaders"
);
}
}