Skip to content

Conversation

@veresov
Copy link
Contributor

@veresov veresov commented Apr 25, 2025

Improve warm-up time by making profile data from a previous run of an application instantly available, when the HotSpot Java Virtual Machine starts. Specifically, enhance the AOT cache to store method execution profiles from training runs, reducing profiling delays in subsequent production runs.

More details in the JEP: https://bugs.openjdk.org/browse/JDK-8325147


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8356012 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8355003: Implement JEP 515: Ahead-of-Time Method Profiling (Sub-task - P4)
  • JDK-8356012: Implement JEP 515: Ahead-of-Time Method Profiling (CSR)

Reviewers

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24886/head:pull/24886
$ git checkout pull/24886

Update a local copy of the PR:
$ git checkout pull/24886
$ git pull https://git.openjdk.org/jdk.git pull/24886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24886

View PR using the GUI difftool:
$ git pr show -t 24886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24886.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355003: Implement JEP 515: Ahead-of-Time Method Profiling

Co-authored-by: John R Rose <[email protected]>
Co-authored-by: Vladimir Ivanov <[email protected]>
Co-authored-by: Ioi Lam <[email protected]>
Co-authored-by: Vladimir Kozlov <[email protected]>
Co-authored-by: Aleksey Shipilev <[email protected]>
Reviewed-by: kvn, ihse, cjplummer, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed merge-conflict Pull request has merge conflict with target branch labels May 13, 2025
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates are good!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels May 14, 2025
@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed ready Pull request is ready to be integrated merge-conflict Pull request has merge conflict with target branch labels May 20, 2025
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 28, 2025
@veresov
Copy link
Contributor Author

veresov commented May 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2025

Going to push as commit e3f85c9.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2025
@openjdk openjdk bot closed this May 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

@veresov Pushed as commit e3f85c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.