8355611: Get rid of SurfaceManagerFactory

[YaaZ]

SurfaceManagerFactory just checks a given GraphicsConfiguration against multiple types via instanceof, it has 3 platform-specific implementations, which rely on an ugly injection process.

There is no reason to have this class at all, we could just let GraphicsConfiguration create a compatible SurfaceManager instead.

This would reduce coupling without having to collect all surface manager types in a single place (without real need to do so).
And this would also remove dependency on the class initialization sequence by getting rid of the injection process.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355611: Get rid of SurfaceManagerFactory (Enhancement - P5)

Reviewers

• Phil Race (@prrace - Reviewer) Review applies to c1e55120
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24875/head:pull/24875
$ git checkout pull/24875

Update a local copy of the PR:
$ git checkout pull/24875
$ git pull https://git.openjdk.org/jdk.git pull/24875/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24875

View PR using the GUI difftool:
$ git pr show -t 24875

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24875.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ngubarkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaaZ This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355611: Get rid of SurfaceManagerFactory

Reviewed-by: serb, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 4e7b513: 8351333: [ubsan] CDSMapLogger::log_region applying non-zero offset to null pointer
• 898d479: 8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization
• 21b0f5e: 8355637: SSLSessionImpl's "serialization" list documentation is incorrectly ordered
• ... and 22 more: https://git.openjdk.org/jdk/compare/e01e33d19b94ee85f7cb7cd6baec857a50086c76...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@YaaZ The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (3741484e)
• 01: Full - Incremental (c1e55120)
• 00: Full (1dd93bdf)

[prrace]

It seems like a nice simplification, but I'm running all our tests to make sure there are no unpleasant surprises.

[YaaZ]

/integrate

[openjdk]

@YaaZ
Your change (at version 3741484) is now ready to be sponsored by a Committer.

[avu]

/sponsor

[openjdk]

Going to push as commit 40e7986.
Since your change was applied there have been 29 commits pushed to the master branch:

• 1f228e5: 8354119: Missing C2 proper allocation failure handling during initialization (during generate_uncommon_trap_blob)
• cd6f0d1: 8355336: GenShen: Resume Old GC even with back-to-back Young GC triggers
• 9c86ac2: 8354495: Open source several AWT DataTransfer tests
• ... and 26 more: https://git.openjdk.org/jdk/compare/e01e33d19b94ee85f7cb7cd6baec857a50086c76...master

Your commit was automatically rebased without conflicts.

[openjdk]

@avu @YaaZ Pushed as commit 40e7986.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.