-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8342886: Update MET timezone in TimeZoneNames files #24871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MET timezone entry in TimeZoneNames.java and TimeZoneNames_*.java needs to be updated as MET is alias to Europe/Brussels as per 2024b tzdata changes. Also Bug4848242.java needs to be removed as the test expects all euro locale time zones should have the same short names.
|
👋 Welcome back gauthamkrishnanibm! A progress list of the required criteria for merging this PR into |
|
@gauthamkrishnanibm This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 74 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@gauthamkrishnanibm The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
Thanks for the contribution.
I think this is still worth testing, with comments adjusted (not every euro country, but sampled ones do have the same short names) |
Reverting the change to delete Bug4848242.java as it is still worth testing, with comments adjusted.
|
@naotoj Thanks for reviewing. Agreed that the Bug4848242.java is still worth testing, with comments adjusted. |
naotoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing back the test case. Please add the bug id 8342886 in the test header.
|
@naotoj updated. Thanks |
|
You'll need to append "8342886" to the |
|
@naotoj updated. Thanks |
Co-authored-by: Naoto Sato <[email protected]>
naotoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Confirmed T1-T3 tests succeeded in our CI system
|
/integrate |
|
@gauthamkrishnanibm |
|
/sponsor |
|
Going to push as commit 6612281.
Your commit was automatically rebased without conflicts. |
|
@naotoj @gauthamkrishnanibm Pushed as commit 6612281. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
MET timezone entry in TimeZoneNames.java and TimeZoneNames_*.java needs to be updated as MET is alias to Europe/Brussels as per 2024b tzdata changes.
Also Bug4848242.java needs to be removed as the test expects all euro locale time zones should have the same short names.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24871/head:pull/24871$ git checkout pull/24871Update a local copy of the PR:
$ git checkout pull/24871$ git pull https://git.openjdk.org/jdk.git pull/24871/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24871View PR using the GUI difftool:
$ git pr show -t 24871Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24871.diff
Using Webrev
Link to Webrev Comment