8350703: Add standard system property stdin.encoding #24738

stuart-marks · 2025-04-17T18:59:33Z

Windows and Unix: set sprops.stdin_encoding if connected to a console
Add specs for stdin.encoding
Adjust specs to change "undefined" to "unspecified"
Rewrite System.in spec to refer to new property and to clarify usage with classes that perform encoding
Update property test

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Change requires CSR request JDK-8355357 to be approved
Commit message must refer to an issue

Issues

JDK-8350703: Add standard system property stdin.encoding (Enhancement - P4)
JDK-8355357: Add standard system property stdin.encoding (CSR)

Reviewers

Naoto Sato (@naotoj - Reviewer)
Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24738/head:pull/24738
$ git checkout pull/24738

Update a local copy of the PR:
$ git checkout pull/24738
$ git pull https://git.openjdk.org/jdk.git pull/24738/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24738

View PR using the GUI difftool:
$ git pr show -t 24738

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24738.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-17T19:00:33Z

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-17T19:00:57Z

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350703: Add standard system property stdin.encoding

Reviewed-by: naoto, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 138 new commits pushed to the master branch:

597bcc6: 8352003: Support --add-opens with -XX:+AOTClassLinking
5c06723: 8355074: RISC-V: C2: Support Vector-Scalar version of Zvbb Vector And-Not instruction
a2f9c24: 8354327: Rewrite runtime/LoadClass/LoadClassNegative.java
... and 135 more: https://git.openjdk.org/jdk/compare/7b0618859a7764b0d4c8b893a19dfb64f4351c07...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-17T19:01:30Z

@stuart-marks The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

stuart-marks · 2025-04-22T22:59:58Z

/csr

openjdk · 2025-04-22T23:00:39Z

@stuart-marks has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@stuart-marks please create a CSR request for issue JDK-8350703 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

mlbridge · 2025-04-22T23:04:32Z

Webrevs

naotoj

Looks good. Is a corresponding CSR being drafted?

naotoj · 2025-04-23T01:33:39Z

src/java.base/share/classes/jdk/internal/util/SystemProps.java

-        // purposes, substitute them with "sun.*" if they don't exist. If "sun.*" aren't
-        // available either, fall back to "native.encoding".
+        // Encoding properties for stdin, stdout, and stderr. For stdout and stderr,
+        // check "sun.*.encoding" properties before falling back to the


Could explain about sun* a bit more (just for compatibility) and stdin.encoding is free from it.

I think the comment could be clearer. As I understand it, it's just trying to saying that the legacy sun.stdout.encoding/sun.stderr.encoding properties for stdout/stderr only, no equivalent for stdin.

Yeah the comment was a bit terse so I tried to clarify it.

Thanks, it looks okay now.

naotoj · 2025-04-23T01:34:42Z

src/java.base/windows/native/libjava/java_props_md.c

        LCID userDefaultUILCID = MAKELCID(userDefaultUILang, SORTIDFROMLCID(userDefaultLCID));

        {
+            HANDLE hStdIn;


Instead of creating a new variable, hStdOutErr could be reused with a proper name.

OK I merged the local variables into a single one named hStdHandle. I'm not sure that's the best name. I surmise that the h prefix is "Hungarian Notation" to indicate that it's a handle, though it makes the name kind of redundant.

…riable name.

AlanBateman · 2025-04-23T12:55:45Z

Overall I think this looks quite good. Follow-up PR can update APIs beyond System to reference it.

stuart-marks · 2025-04-23T17:13:46Z

OK thanks. Working on the CSR.

naotoj

LGTM

stuart-marks · 2025-04-25T16:32:13Z

/integrate

openjdk · 2025-04-25T16:32:48Z

Going to push as commit 15f42e3.
Since your change was applied there have been 139 commits pushed to the master branch:

77f5a24: 8355214: nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001.java should use JDIBase superclass
597bcc6: 8352003: Support --add-opens with -XX:+AOTClassLinking
5c06723: 8355074: RISC-V: C2: Support Vector-Scalar version of Zvbb Vector And-Not instruction
... and 136 more: https://git.openjdk.org/jdk/compare/7b0618859a7764b0d4c8b893a19dfb64f4351c07...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-25T16:32:55Z

@stuart-marks Pushed as commit 15f42e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

stuart-marks added 2 commits April 17, 2025 11:52

8350703: first cut at stdin.encoding

b4e88cf

Fix typo stdout => stdin

1089d6f

openjdk bot added the core-libs [email protected] label Apr 17, 2025

stuart-marks added 4 commits April 22, 2025 15:36

Revise spec of System.in to mention stdin.encoding.

630d99b

wordsmith

2b9ad4a

moar wordsmithing

d32004b

Even moar wordsmithing.

42933bc

stuart-marks marked this pull request as ready for review April 22, 2025 22:59

openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Apr 22, 2025

naotoj reviewed Apr 23, 2025

View reviewed changes

Update sun.stdout/err.encoding comments; tweak Windows file handle va…

5357e50

…riable name.

Yet another minor bit of wordsmithing.

c4bf316

AlanBateman approved these changes Apr 23, 2025

View reviewed changes

naotoj approved these changes Apr 24, 2025

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Apr 25, 2025

openjdk bot added the integrated Pull request has been integrated label Apr 25, 2025

openjdk bot closed this Apr 25, 2025

openjdk bot removed the ready Pull request is ready to be integrated label Apr 25, 2025

openjdk bot removed the rfr Pull request is ready for review label Apr 25, 2025

lahodaj mentioned this pull request Apr 27, 2025

8344706: Implement JEP 512: Compact Source Files and Instance Main Methods #24438

Closed

5 tasks

graalvmbot mentioned this pull request Jun 10, 2025

[GR-65610] Update labsjdk to 25+26-jvmci-b01 oracle/graal#11374

Merged

8350703: Add standard system property stdin.encoding #24738

8350703: Add standard system property stdin.encoding #24738

Uh oh!

Conversation

stuart-marks commented Apr 17, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issues

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

stuart-marks commented Apr 22, 2025

Uh oh!

openjdk bot commented Apr 22, 2025

Uh oh!

mlbridge bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

naotoj left a comment

Choose a reason for hiding this comment

Uh oh!

naotoj Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

AlanBateman Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

stuart-marks Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

AlanBateman Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

stuart-marks Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

AlanBateman commented Apr 23, 2025

Uh oh!

stuart-marks commented Apr 23, 2025

Uh oh!

naotoj left a comment

Choose a reason for hiding this comment

Uh oh!

stuart-marks commented Apr 25, 2025

Uh oh!

openjdk bot commented Apr 25, 2025

Uh oh!

openjdk bot commented Apr 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

stuart-marks commented Apr 17, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 17, 2025 •

edited

Loading

mlbridge bot commented Apr 22, 2025 •

edited

Loading