-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8348986: Improve coverage of enhanced exception messages #23929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Michael-Mc-Mahon
wants to merge
40
commits into
openjdk:master
from
Michael-Mc-Mahon:8348986-exceptions
Closed
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
269efa3
initial impl
Michael-Mc-Mahon 466dab4
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 690cdb1
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon b941943
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 3047d6d
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon ccb31ea
update
Michael-Mc-Mahon 55a43f7
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon fce5f69
update
Michael-Mc-Mahon d94e95d
update
Michael-Mc-Mahon c6df8de
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 23f9ee0
moved test
Michael-Mc-Mahon fa25ccc
whitespace
Michael-Mc-Mahon c441986
remove file added by mistake
Michael-Mc-Mahon 074da25
doc + copyright update
Michael-Mc-Mahon 41d1ef8
Apply suggestions from code review
Michael-Mc-Mahon 33d1191
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon f5501d1
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon c41146b
update to minimise code changes
Michael-Mc-Mahon bd5438f
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon da33863
review update
Michael-Mc-Mahon efabc48
Review update
Michael-Mc-Mahon 9401d4c
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 1a14f4b
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 160d561
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 50a1bea
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 3b7861b
reduced number of new categories
Michael-Mc-Mahon dea5080
update
Michael-Mc-Mahon cc518c1
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon c723891
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon cf179f7
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 34f20c9
Additional callsites identified by Mark S.
Michael-Mc-Mahon cf5233c
Apply suggestions from code review
Michael-Mc-Mahon 021b841
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 462ee01
typo in suggestions and other issues
Michael-Mc-Mahon 3eec6c0
Fixed problem with j.n.HostPortRange
Michael-Mc-Mahon 5970c2b
doc update to java.security
Michael-Mc-Mahon b582a0f
removed jmod/Handler change
Michael-Mc-Mahon 4aad014
doc update to java.security
Michael-Mc-Mahon ab6387d
Merge branch 'master' into 8348986-exceptions
Michael-Mc-Mahon 1a6f5af
uodate to JNDI
Michael-Mc-Mahon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could take the opportunity to update the HostPortrange constructor signature refactor rename
the parameter str to hostname ;-)