8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration #22281

dfuch · 2024-11-20T19:39:58Z

This PR remove usage of SecurityManager, doPrivileges, etc... from java.logging and java.base/jdk.internal.logger

Only notable hack - Logger.checkPermission() no longer checks permissions, but has been renamed into ensureLogManagerInitialized() in order to avoid disturbing the initialization sequence of Logger/LogManager.

I am not 100% sure this is still needed - but I remember we had some entanglement issues in the past that had been hard to solve, so it seemed prudent to keep the call:

    if (manager == null) {
        manager = LogManager.getLogManager();
    }

where manager is a private volatile field in Logger.

I also took the opportunity to remove the locking workaround that had been introduced to support Virtual Threads and revert to using synchronized in the Handler classes now that JEP 491 has been integrated.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration (Bug - P4)

Reviewers

Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22281/head:pull/22281
$ git checkout pull/22281

Update a local copy of the PR:
$ git checkout pull/22281
$ git pull https://git.openjdk.org/jdk.git pull/22281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22281

View PR using the GUI difftool:
$ git pr show -t 22281

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22281.diff

Using Webrev

Link to Webrev Comment

…integration

bridgekeeper · 2024-11-20T19:41:00Z

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-11-20T19:41:10Z

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

f2b10c6: 8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages
5ccd510: 8326369: Add test to verify bimorphic inlining happens after morphism changes
93aa7e2: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate()
10def48: 8344236: Revisit SecurityManager usage in jdk.net after JEP 486 integration
7105bb9: 8344664: Remove some un-used java/sun.security imports in the java.desktop module
a01aa22: 8342281: Deprecate for removal javax.sound.sampled.AudioPermission
4fbf272: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize
1343911: 8340334: Update jcmd VM.events max parameter to be INT
400eb9b: 8344524: Remove SecurityManager related code from jdk.jlink module
a599c30: 8344471: Remove SecurityManager related code from java.compiler module
... and 5 more: https://git.openjdk.org/jdk/compare/c4c6b1fe0629d313e7b7bd6b7dc92f8c7d18ec8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-11-20T19:41:49Z

@dfuch The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-11-20T19:44:26Z

Webrevs

01: Full - Incremental (ef8b71e1)
00: Full (169e8c20)

RogerRiggs

Looks good

RogerRiggs · 2024-11-20T20:29:06Z

src/java.base/share/classes/jdk/internal/logger/LoggerFinderLoader.java

-        final Iterator<System.LoggerFinder> iterator;
-        if (System.getSecurityManager() == null) {
-            iterator = ServiceLoader.load(System.LoggerFinder.class,
+        final Iterator<System.LoggerFinder> iterator =


Could be simply be return ... no need for a local var.

jaikiran

Hello Daniel, the changes look good to me. However, these changes appear to include both JEP 486 related updates as well as the JEP 491 (the reverting of ReentrantLock usage in favour of synchronized). Doing this clean up together I think is fine. However, I think we should update the issue title to also include JEP 491 in addition to JEP 486.

dfuch · 2024-11-21T10:17:45Z

Hello Daniel, the changes look good to me. However, these changes appear to include both JEP 486 related updates as well as the JEP 491 (the reverting of ReentrantLock usage in favour of synchronized). Doing this clean up together I think is fine. However, I think we should update the issue title to also include JEP 491 in addition to JEP 486.

Oh right. I should have mentioned that in the summary. This is now done, I modified the JBS and PR titles as suggested too.

jaikiran

This looks good to me.

dfuch · 2024-11-21T11:53:56Z

/integrate

openjdk · 2024-11-21T11:54:30Z

Going to push as commit a62279c.
Since your change was applied there have been 16 commits pushed to the master branch:

18df6fd: 8336707: Contention of ForkJoinPool grows when stealing works
f2b10c6: 8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages
5ccd510: 8326369: Add test to verify bimorphic inlining happens after morphism changes
93aa7e2: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate()
10def48: 8344236: Revisit SecurityManager usage in jdk.net after JEP 486 integration
7105bb9: 8344664: Remove some un-used java/sun.security imports in the java.desktop module
a01aa22: 8342281: Deprecate for removal javax.sound.sampled.AudioPermission
4fbf272: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize
1343911: 8340334: Update jcmd VM.events max parameter to be INT
400eb9b: 8344524: Remove SecurityManager related code from jdk.jlink module
... and 6 more: https://git.openjdk.org/jdk/compare/c4c6b1fe0629d313e7b7bd6b7dc92f8c7d18ec8f...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-11-21T11:54:42Z

@dfuch Pushed as commit a62279c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

dfuch added 2 commits November 20, 2024 18:51

8344235: Revisit SecurityManager usage in java.logging after JEP 486 …

7e92d2c

…integration

8344235: Revisit SecurityManager usage in java.logging after JEP 486 …

169e8c2

…integration

openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024

openjdk bot added the core-libs [email protected] label Nov 20, 2024

dfuch mentioned this pull request Nov 20, 2024

8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker #22282

Closed

3 tasks

RogerRiggs reviewed Nov 20, 2024

View reviewed changes

graalvmbot mentioned this pull request Nov 20, 2024

[JDK-8344655] Adapt JDK-8344235: Revisit SecurityManager usage in java.logging after JEP 486 integration oracle/graal#10127

Merged

jaikiran reviewed Nov 21, 2024

View reviewed changes

dfuch changed the title ~~8344235: Revisit SecurityManager usage in java.logging after JEP 486 integration~~ 8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration Nov 21, 2024

Review feedback

ef8b71e

jaikiran approved these changes Nov 21, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2024

openjdk bot added the integrated Pull request has been integrated label Nov 21, 2024

openjdk bot closed this Nov 21, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration #22281

8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration #22281

dfuch commented Nov 20, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 20, 2024

openjdk bot commented Nov 20, 2024 •

edited

Loading

openjdk bot commented Nov 20, 2024

mlbridge bot commented Nov 20, 2024 •

edited

Loading

RogerRiggs left a comment

RogerRiggs Nov 20, 2024

dfuch Nov 21, 2024

jaikiran left a comment

dfuch commented Nov 21, 2024

jaikiran left a comment

dfuch commented Nov 21, 2024

openjdk bot commented Nov 21, 2024

openjdk bot commented Nov 21, 2024

8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration #22281

8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration #22281

Conversation

dfuch commented Nov 20, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 20, 2024

openjdk bot commented Nov 20, 2024 • edited Loading

openjdk bot commented Nov 20, 2024

mlbridge bot commented Nov 20, 2024 • edited Loading

Webrevs

RogerRiggs left a comment

Choose a reason for hiding this comment

RogerRiggs Nov 20, 2024

Choose a reason for hiding this comment

dfuch Nov 21, 2024

Choose a reason for hiding this comment

jaikiran left a comment

Choose a reason for hiding this comment

dfuch commented Nov 21, 2024

jaikiran left a comment

Choose a reason for hiding this comment

dfuch commented Nov 21, 2024

openjdk bot commented Nov 21, 2024

openjdk bot commented Nov 21, 2024

dfuch commented Nov 20, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Nov 20, 2024 •

edited

Loading

mlbridge bot commented Nov 20, 2024 •

edited

Loading