Skip to content

Conversation

@mdykman
Copy link
Contributor

@mdykman mdykman commented Mar 28, 2012

No description provided.

@effbiae
Copy link
Member

effbiae commented Mar 29, 2012

ordinarily, i might like platform specific code put in it's own file (eg. define exit(int) in a .c file). especially with the jni stuff. however, it doesn't really differ from the context. i'd say OK to pull unless others have any issues

@mdykman
Copy link
Contributor Author

mdykman commented Mar 29, 2012

I think it cleaner than a separate file for so small a detail. It
leaves the code more maintainable and keeps the build process simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants