-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvements to the WMC tool #174
base: dev
Are you sure you want to change the base?
Conversation
Thanks @malenov for the update. Shall we consider the code as stable and ready for review? Do we need to update the manual? I've seen that usage for wmc_tool.c has been updated, so I expect wmc_tool.tex to be updated to reflect the changes? |
@ludomal, thanks for noticing this. You're right. I've updated the manual by adding some information describing the the newly supported command-line argument. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for inclusion to the proposal for the next release of STL.
The update compiles and passes test vectors.
…ter versions of Cmake
… skipping complexity instrumentation in function bodies
Dear @ludomal, I've made a small modification in the CMakeLists.txt that I'd like you to review. The |
…tatements due to INSTRUMENTATION_OFF
…on plus some instrumented code, e.g. encoder.c
…e but before the last automatically instrumented segment
…et_indices(), write_indices(), read_indices(), read_bitstream_info(), reset_stack() and push_stack() from the list of reserved function names
…unction - update of memory consumption counters is part of update_wmops() - replace the code updating the worst-case intra-frame and inter-frame heap memory consumption - support for per-frame and per-block memory consumption exported to a .csv file - fix incorrect calculation of the worst-case heap size for memory blocks allocated and de-allocated multiple times in a single frame
…sed on the .csv memory output file generated by the WMC tool
…placing constants MAX_RECORDS and MAX_RECORDABLE_CALLS), allows for re-allocation if max size is exceeded
…f, cosf, sqrtf, ...)
add explanation about where to place the push_wmops() function calls
…ter versions of Cmake
… skipping complexity instrumentation in function bodies
…tatements due to INSTRUMENTATION_OFF
…on plus some instrumented code, e.g. encoder.c
…e but before the last automatically instrumented segment
…ounting mechanism
…as regular functions
@malenov , looks like you did quite a few updates to the WMC tool. These changes appear into the April 2024 PR that was already approved and merged. If you would like to incorporate these changes to the STL, would you mind creating a new Pull Request? |
@ludomal, you’re correct. I’ve made several updates and added new features to the WMC tool, now at version v1.7. There’s still room for minor enhancements and potential fixes in the coming months, so the branch isn’t ready for review yet. Once it’s finalized, I’ll create a new Pull Request and request a formal review. Thank you! |
This is an update of the WMC tool addressing issues listed in #172.