Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop AppInfo Service #6

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Develop AppInfo Service #6

merged 1 commit into from
Apr 22, 2021

Conversation

seungkyua
Copy link
Contributor

@seungkyua seungkyua commented Apr 22, 2021

아래 func 를 구현했음

  • client example code
  • AddApp
  • DeleteApp
  • GetAppIDs
  • GetAllAppsByClusterID
  • GetAppsByName
  • GetAppsByType
  • GetApp
  • UpdateApp
  • UpdateAppStatus
  • UpdateEndpoints

if err != nil {
log.Fatal("error while calling GetAllAppsByClusterID RPC", err)
}
log.Info("Response from GetAllAppsByClusterID: ", res)
Copy link
Contributor

@zugwan zugwan Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 res.GetApps()를 호출하지 않는 건 이유가 있는 건가요? 아래 doGetApp() 형태의 모든 메서드에 해당하는 질문입니다.

Copy link
Contributor Author

@seungkyua seungkyua Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(수정) res 를 프린트해도 Apps 의 내용이 다 프린트되서요. 특별한 이유는 없습니다.

@zugwan zugwan self-requested a review April 22, 2021 08:20
Copy link
Contributor

@zugwan zugwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seungkyua seungkyua merged commit 823bb10 into main Apr 22, 2021
@seungkyua seungkyua deleted the app_info branch April 22, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants