Build and push docker image when merged #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
reviewed
Sep 2, 2021
.github/workflows/deploy-image.yml
Outdated
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
PR 일 때도 이미지 push 되는거 아닌가요? build만 해야하지 않을까 싶습니다.
There was a problem hiding this comment.
만약 pull_request 가 PR merged 가 아닌 PR 만이라면 build 만 해야 할 것 같네요.
ktkfree
reviewed
Sep 2, 2021
.github/workflows/deploy-image.yml
Outdated
| file: Dockerfile | ||
| push: true | ||
| tags: | | ||
| docker.pkg.github.com/${{ github.repository }}/tks-cluster-lcm:latest |
There was a problem hiding this comment.
버전명으로 명시하여 build 하고, tag 해야 하지 않을까요? latest 는 심볼릭 링크처럼 사용하는게 아닐까하여 코멘트합니다.
seungkyua
force-pushed
the
docker_build_and_push
branch
4 times, most recently
from
f3c3d8e to
1239091
Compare
seungkyua
force-pushed
the
docker_build_and_push
branch
from
1239091 to
2f355bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr 을 올리면 pr 의 source branch 명을 태그로 붙혀서 docker.io/seungkyua/tks-cluster-lcm:[branch명] 으로 이미지를 저장함
merge 되면 docker.io/seungkyua/tks-cluster-lcm:latest 로 이미지를 저장함