Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug. add validation for delete cluster #32

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Mar 15, 2022

버그 수정 PR 입니다.

cluster 삭제시 이미 삭제된 cluster 로 요청시 실패처리하도록 validation 을 추가합니다.

@ktkfree ktkfree requested a review from Jaesang March 15, 2022 07:38
Copy link
Contributor

@Jaesang Jaesang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 피드백 감사합니다.
그런데 이미 지워졌다고 알려주기보다는,
"지워지는 중"이거나 "없는 클러스터"로 하는게 더 적절해보입니다.
여기서 없는 클러스터라는 것은 "Could not find Cluster with ID' 라는 기존 메시지를 그대로 사용하는 것입니다.

@ktkfree ktkfree force-pushed the validation_for_delete_cluster branch from b8a9e76 to a94ad99 Compare March 15, 2022 07:55
@ktkfree
Copy link
Contributor Author

ktkfree commented Mar 15, 2022

빠른 피드백 감사합니다. 그런데 이미 지워졌다고 알려주기보다는, "지워지는 중"이거나 "없는 클러스터"로 하는게 더 적절해보입니다. 여기서 없는 클러스터라는 것은 "Could not find Cluster with ID' 라는 기존 메시지를 그대로 사용하는 것입니다.

Could not find cluster with ID 로 통일했습니다. deleting, deleted 각 상태별로 안내하는 것이 가장 친절하겠지만, 이 정도 문구면 괜찮을 것 같네요.

@ktkfree ktkfree force-pushed the validation_for_delete_cluster branch from a94ad99 to ae08ad9 Compare March 15, 2022 07:59
@ktkfree ktkfree requested a review from Jaesang March 15, 2022 08:03
@Jaesang Jaesang merged commit e375e08 into main Mar 15, 2022
@Jaesang Jaesang deleted the validation_for_delete_cluster branch March 15, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants