Resolve lma reinstallation failure #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 15, 2022 15:19
ktkfree
requested review from
Jaesang,
zugwan,
intelliguy,
robertchoi80 and
seungkyua
robertchoi80
approved these changes
Feb 16, 2022
zugwan
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMA 설치시 중복하여 요청할 경우 실패하던 현상을 변경합니다.
AS-IS : 동일한 cluster 에 동일한 externalLabel 로 서비스 설치를 요청할 경우, externalLabel 중복으로 인해 AppGroup 생성 오류가 발생합니다.
TO-BE : 동일한 clueter 에 동일한 externalLabel 이 존재할 경우 해당 AppGroupId 를 사용하며, 존재하지 않을 경우 AppGroup 을 생성합니다.
추가 변경 사항
. error response 의 경우 err 를 return 하도록 변경
. default logging-component 를 "efk" 에서 "loki" 로 변경