lma: prometheus: fix kubeetcd endpoints #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
requested review from
Jaesang,
ktkfree,
intelliguy,
robertchoi80 and
seungkyua
|
이거는 @intelliguy 님도 아셔야 하는 내용일까요? |
먼저 작업을 하셨던 분이니 확인을 해주시면 좋습니다. |
intelliguy
reviewed
Mar 19, 2022
hanu-reference/lma/site-values.yaml
Outdated
| @@ -24,8 +24,7 @@ charts: | |||
|
|
|||
| - name: prometheus | |||
| override: | |||
| kubeEtcd.endpoints: | |||
| - 172.27.1.222 | |||
| kubeEtcd.endpoints: [] # If your etcd is not deployed as a pod, specify IPs it can be found on | |||
There was a problem hiding this comment.
이 값이 default여서 이예 정의하지 않는것이 더 좋습니다. (27라인 삭제)
zugwan
force-pushed
the
fix_prometheus_kubeetcd
branch
from
9a22792 to
32b1cf0
Compare
intelliguy
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube-prometheus-stack 차트는 POD로 실행되는 etcd의 exporter 아이피를 서비스 셀렉터를 통해 자동 구성하는 방법을 지원합니다. 이를 위해 kubeEtcd.endpoints 리스트가 비어 있어야 하기 때문에 해당 내용으로 정리하였습니다.