Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render-cd 스크립트를 오프라인 등 환경에 사용하기 위해 설정 가능한 부분을 추가 #67

Merged
merged 8 commits into from
Nov 16, 2021

Conversation

zugwan
Copy link
Contributor

@zugwan zugwan commented Nov 11, 2021

오프라인 혹은 내부 저장소/레지스트리 운영 환경 등 상황에 대응하기 위해 관련 부분을 설정할 수 있도록 수정하였습니다.

@intelliguy
Copy link
Contributor

.github/workflows/render-cd.sh 를 call하는 쪽에서는 어떻게 호출해야 하나요? 옵션을 줄때

@zugwan
Copy link
Contributor Author

zugwan commented Nov 12, 2021

.github/workflows/render-cd.sh 를 call하는 쪽에서는 어떻게 호출해야 하나요? 옵션을 줄때

다음 옵션이 사용 가능하고 옵션을 주지 않으면 기존과 동일하게 동작합니다.
[--site TARGET_SITE] [--base_url DECAPOD_BASE_URL] [--registry REGISTRY_URL]

@zugwan zugwan force-pushed the configurable_render-cd branch 3 times, most recently from bced803 to dda162a Compare November 13, 2021 02:06
(*) exit 1;; # error
esac
done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 수정사항 정말 좋은것 같습니다. 그런데, 테스트해보니 잘 안되는것 같은데요. 한번 체크 부탁 드립니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 어떤 오류가 발생하는 지 공유해 주실 수 있을까요? 저는 문제 없이 사용하고 있어서 요청 드립니다.

Copy link
Contributor

@ktkfree ktkfree Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

35line에 요렇게 추가하고
echo DOCKER_IMAGE_REPO $DOCKER_IMAGE_REPO; echo GITHUB_IMAGE_REPO $GITHUB_IMAGE_REPO

아래 명령어 실행시 변경되지 않는 걸로 나와서요. 자세히 디버깅은 해보지 않았어요.
shell script 가 익숙치 않아서...제가 잘못사용한걸 수도 있습니다.

.github/workflows/render-cd.sh --registry aa

결과
DOCKER_IMAGE_REPO docker.io
GITHUB_IMAGE_REPO ghcr.io

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음, 이상하네요. 말씀하신 수정 내용 추가하고 실행하면 아래처럼 정상 동작하는 것으로 나타납니다.

 .github/workflows/render-cd.sh --registry aa
DOCKER_IMAGE_REPO aa
GITHUB_IMAGE_REPO aa
[render-cd] dacapod branch=main, output target=output ,target site(s)=hanu-reference\n\n
Fetch base with main branch/tag........
Cloning into 'decapod-base-yaml'...
remote: Enumerating objects: 1213, done.
remote: Counting objects: 100% (218/218), done.
remote: Compressing objects: 100% (126/126), done.
remote: Total 1213 (delta 111), reused 121 (delta 89), pack-reused 995
Receiving objects: 100% (1213/1213), 303.20 KiB | 1.68 MiB/s, done.
Resolving deltas: 100% (465/465), done.
mkdir: cannot create directory ‘output’: File exists
[render-cd] Starting build manifests for 'hanu-reference' site
Rendering decapod-controller-manifest.yaml for hanu-reference site
Unable to find image 'aa/sktdev/decapod-kustomize:latest' locally
docker: Error response from daemon: pull access denied for aa/sktdev/decapod-kustomize, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시나 싶어서 centos 에서 테스트해보니 잘되는군요. 제 맥 환경(zsh)의 문제인듯 합니다. 감사합니다~

@zugwan zugwan force-pushed the configurable_render-cd branch from e0765a7 to 1e0359e Compare November 15, 2021 07:58
@Jaesang Jaesang merged commit 0f3661d into main Nov 16, 2021
@Jaesang Jaesang deleted the configurable_render-cd branch November 16, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants