Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

오프라인 환경을 위한 사이트 생성 스크립트 수정 #66

Merged
merged 5 commits into from
Nov 10, 2021

Conversation

zugwan
Copy link
Contributor

@zugwan zugwan commented Nov 9, 2021

decapod-base-yaml 저장소 기준으로 신규 사이트를 생성하던 기존 스크립트를 오프라인 환경에 대한 지원을 추가하기 위해 아래와 같이 변경하였습니다.

  • 온라인, 오프라인용 참고 사이트를 기반으로 생성: hanu-reference / hanu-reference-offline
  • 오프라인 환경에서 Helm 패키지 저장소와 이미지 레지스트리 값은 사이트 생성 시 입력
    • 예) ./create_site.sh offline-site --helm-repo http://172.16.10.62:8879/charts --registry gate-centos-lb-local-path-offline-multi-rwnzwy-1

그 외에 현재 사용되지 않는 부분 등은 제거하였습니다.

@gitguardian
Copy link

gitguardian bot commented Nov 9, 2021

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Slack Webhook URL 1f711ad gate-centos-lb-ceph-online-multinodes/lma/site-values.yaml 07:48 October 29th, 2021 View secret
🛠 How to resolve this
  1. Understand the implications of revoking this secret by examining where it is used in your code.

  2. Replace and store your secret safely. Learn here the best practices

  3. Revoke and rotate this secret

  4. If possible, rewrite your git history to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.

💡 To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.

You are seeing this because you or someone else has authorized GitGuardian to scan pull requests

@Jaesang
Copy link
Contributor

Jaesang commented Nov 9, 2021

@zugwan gate-폴더에 있는 app yaml들을 모두 삭제하였는데, 이 PR 이후 해당 app들은 어떻게 설치/관리되나요?

@zugwan
Copy link
Contributor Author

zugwan commented Nov 9, 2021

@zugwan gate-폴더에 있는 app yaml들을 모두 삭제하였는데, 이 PR 이후 해당 app들은 어떻게 설치/관리되나요?

현재 decapod-flow 에서 참조하는 사이트는 hanu-reference 입니다.(LMA 예: https://github.com/openinfradev/decapod-flow/blob/8a76e58b603be1a0851d6dc9d9b66cbcd0ee0a21/templates/decapod-apps/lma-uniformed-wftpl.yaml#L10) 제가 확인해본 바로는 gate-* 사이트는 사용되는 경우가 없고 관리도 되고 있지 않아서 삭제하였습니다.

@zugwan zugwan merged commit 4d3b83d into main Nov 10, 2021
@zugwan zugwan deleted the v2_air-gap branch November 10, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants