TACODEV-776: generate resource yamls from helmrelease mannifest #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliguy
force-pushed
the
decapod2
branch
15 times, most recently
from
fe181ff to
61f27d3
Compare
intelliguy
force-pushed
the
decapod2
branch
3 times, most recently
from
81ed466 to
d441f8e
Compare
Jaesang
suggested changes
Apr 19, 2021
.github/workflows/render-cd.sh
Outdated
| BRANCH=$1 | ||
| fi | ||
|
|
||
| # if [ $# -eq 2 ]; then |
.github/workflows/render-cd.sh
Outdated
| if [ $? -ne 0 ]; then | ||
| exit $? | ||
| fi | ||
| # git clone -b $CD_BRANCH $CD_FILE_TARGET_URL cd |
| exit 1 | ||
| fi | ||
|
|
||
| docker run --rm -i -v $(pwd)/$i:/$i -v $(pwd)/cd:/cd --name generate siim/helmrelease2yaml:1.0.0 $output cd/$i/$app |
There was a problem hiding this comment.
rendering된 manifest파일을 갖고 이 docker run 명령을 통해 어떤일이 벌어지나요?
render-cd.sh를 실행시켜봤는데, 어떤 일이 벌어졌는지 알수가 없어 코멘트 남깁니다.
참고) 실행 로그 중 service-mesh-manifest.yaml for hanu-deploy-apps site 이후 부분
Rendering service-mesh-manifest.yaml for hanu-deploy-apps site
2021/04/19 06:40:12 Attempting plugin load from '/root/.config/kustomize/plugin/openinfradev.github.com/v1/helmvaluestransformer/HelmValuesTransformer.so'
[hanu-deploy-apps, service-mesh] Successfully Generate Helm-Release Files!
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
[generate istio-operator from https://openinfradev.github.io/hanu-helm-repo as istio-operator in istio-operator]
'NoneType' object is not subscriptable <DirEntry '_1'>
[generate jaeger-operator from https://jaegertracing.github.io/helm-charts as jaeger-operator in lma]
'NoneType' object is not subscriptable <DirEntry '_1'>
[generate kiali-operator from https://kiali.org/helm-charts as kiali-operator in istio-system]
'NoneType' object is not subscriptable <DirEntry '_1'>
[generate service-mesh-resource from https://openinfradev.github.io/hanu-helm-repo as service-mesh-controlplane in istio-system]
'NoneType' object is not subscriptable <DirEntry '_1'>
[generate service-mesh-resource from https://openinfradev.github.io/hanu-helm-repo as service-mesh-gateway in istio-system]
'NoneType' object is not subscriptable <DirEntry '_1'>
There was a problem hiding this comment.
cd 디렉토리 밑에 최종 output file들을 만들어줍니다.
참고로 위에 나타나는 NoneType은 parsing할때 하나씩 나타나는데 내부에서 사용한 awk 특성상 발생하는 것이고
openstack쪽 진행하면서는 통으로 에러가 나는것을 확인할 수 있는데 이는 mastr01 서버에서 챠트를 가져오도록 설정된 부분때문에 발생하는 문제입니다.
에러가 발생하면 무시하면서 할수 있는 부분까지만 진행해주는 action이므로 최종 형상에 대한 확인은 pr을 검토하는 단계에서 잘 확인하고 결정해 줘야합니다. (현재 상태에서 이를 failed로 해버리면 문제가 있을꺼 같아 이렇게 처리하고 있음.. 추후 github 액션이 돌아가는 환경에서 완전하게 맞는 사이트별 manifest가 구성되어야 함!!)
estherk0
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가된 액션은 다음의 두가지 작업을 수행합니다.
main으로 Pull Request가 생성되면 모든 사이트의 모든 앱에 대해 다음과 같은 작업을 수행합니다.
PR이 main으로 merge될 때 모든 사이트의 모든 앱에 대해 다음과 같은 작업을 수행합니다.