Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone ingress nginx #179

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Clone ingress nginx #179

merged 3 commits into from
Oct 10, 2023

Conversation

robertchoi80
Copy link
Contributor

@robertchoi80 robertchoi80 commented Oct 10, 2023

ingress-ngnix 를 tks-admin-tools 그룹에 복사합니다.
nodeSelector 및 namespace 등 설정이 usercluster 배포 시와는 다르므로 별도의 entry가 필요합니다.

다음 PR도 함께 머지되어야 합니다.
openinfradev/decapod-base-yaml#266

@robertchoi80 robertchoi80 changed the base branch from main to develop October 10, 2023 09:23
@ktkfree
Copy link
Contributor

ktkfree commented Oct 10, 2023

*-reference 만 변경이 되었는데, *-msa-reference 는 변경이 필요없을까요?

@robertchoi80
Copy link
Contributor Author

*-reference 만 변경이 되었는데, *-msa-reference 는 변경이 필요없을까요?

네, 어차피 admin cluster에 설치되는 tool들이라 msa 형상 여부와 관계가 없을 것 같아서 *-reference 에만 넣었습니다.

@robertchoi80 robertchoi80 merged commit d65e435 into develop Oct 10, 2023
@robertchoi80 robertchoi80 deleted the clone-ingress-nginx branch October 10, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants