Adds Contentful web provider#2306
Merged
kevinchalet merged 4 commits intoopeniddict:devfrom May 6, 2025
Merged
Conversation
Contributor
Author
|
@kevinchalet It is not clear to me from the build output why the tests are failing. All the tests on my local computer is passing |
kevinchalet
reviewed
May 1, 2025
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.Userinfo.cs
Outdated
Show resolved
Hide resolved
kevinchalet
reviewed
May 1, 2025
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationProviders.xml
Outdated
Show resolved
Hide resolved
Member
|
Thanks for your PR!
Looks like a test was failing due to some crypto issues completely unrelated to your change:
I restarted the build and it's green now 🤣 |
- Removes DisplayName attribute - Moves claim resolution to MapCustomWebServicesFederationClaims
Contributor
Author
|
@kevinchalet I addressed the code review issues as requested |
kevinchalet
reviewed
May 6, 2025
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.Userinfo.cs
Outdated
Show resolved
Hide resolved
…ationHandlers.Userinfo.cs
kevinchalet
reviewed
May 6, 2025
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.Userinfo.cs
Show resolved
Hide resolved
…ationHandlers.Userinfo.cs
Member
|
Merged. Thanks @jerriep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Contentful: