Update the ASP.NET Core/OWIN hosts to support returning authentication properties for errored requests #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n properties for errored requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ASP.NET Core/OWIN hosts to support returning authentication properties - added by OpenIddict itself or stored by the user (e.g for the client, when triggering the challenge) - for errored requests when the "error pass-through" mode is enabled in the client or server options.
Note: it's a best effort: if the error was due to an authentication error, not all the properties will be available (e.g for the client stack, if the
statetoken was invalid or already redeemed, most of the properties won't be available).Fixes #2220.