-
Notifications
You must be signed in to change notification settings - Fork 1
Add comprehensive support for account resolution and management handover #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add 'manage' command to Abstract and Introduction command lists - Add account management handover documentation to Command Usage Overview - Add 'aud_sub' claim definition to Command Token section for account resolution - Register 'aud_sub' and 'managed_by' claims in IANA JWT Claims registry - Complete integration of account resolution features throughout specification These changes enable OPs to take over management of existing RP accounts and provide efficient account lookup using RP internal identifiers.
Co-authored-by: Andrii Deinega <[email protected]>
- Add comprehensive Management Transfer section with manage command details - Separate Account Resolution and Management Transfer into distinct sections - Update Introduction with 'account lifecycle management' terminology - Clarify Success Response with 'OP tenant' specification - Add JSON String type specifications for callback_token and aud_sub claims - Include granularity comment about lifecycle vs session management - Fix typo: 'successful' -> 'successfully' in Success Response - Various editorial improvements for clarity and consistency Addresses suggestions from #27 Co-authored-by: collaborator from original PR review
…vider values - Rename "takeover" command to "migrate" throughout specification - Change "take over" terminology to "migrate" for consistency - Update command identifiers from takeover/takeover_async to migrate/migrate_async - Rename "both" authentication_provider state to "op_migration" - Standardize all authentication_provider values to lowercase (op, rp, op_migration, external, unknown) - Update Authentication Takeover Process to Authentication Migration Process
…ocumentation for consistency
+------+ Command request +------+ | ||
| |---- Command Token ---->| | | ||
| OP | | RP | | ||
| |<-----------------------| | | ||
+------+ Command response +------+ | ||
``` | ||
|
||
## Command Usage Overview | ||
The OP may provide a callback endpoint and a callback token for the RP to request a command be sent by the OP such as a metadata or audit_tenant command, or to send the results of an asynchronous command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this paragraph added in this PR? I didn't think this PR was adding anything new around callback behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not new -- just adding clarification on how the protocol works as the callback was not described here.
At first glance this looks good to me. |
These changes enable OPs to take over management of existing RP accounts and provide efficient account lookup using RP internal identifiers.
#25
see previous comments on old PR that I accidently closed from Karl
#27
Most of his comments have been incorporated in this PR