✨ Add ext reg ena to new TH 64 divsqrt unit #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmach
approved these changes
Jun 19, 2024
|
@michael-platzer LGTM! I missed adding this feature in the PR integrating the new divider. Thanks! |
lucabertaccini
approved these changes
Jun 19, 2024
@lucabertaccini No worries 🙂 thanks a lot for the quick review! |
Lynx005F
pushed a commit
to Lynx005F/cvfpu
that referenced
this pull request
Jul 4, 2024
This reverts commit 6b8c4e0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the external register enable signal to the wrapper of the new TH64 div/sqrt unit, in the same fashion as it has been added to the other opgroups in #89. As with these earlier changes, if the new
reg_ena_iport is tied to'0, then the logic remains semantically equivalent.