Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant RTL from multiplier file #937

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

M-Ijaz-10x
Copy link
Contributor

Hey @zarubaf, @JeanRochCoulon

As mentioned in issue#863, the following two lines are not being used in the entire module, so they seem to be redundant:

logic [riscv::XLEN*2-1:0] mult_result;
assign mult_result   = $signed({operand_a_i[riscv::XLEN-1] & sign_a, operand_a_i}) * 
                                     $signed({operand_b_i[riscv::XLEN-1] & sign_b, operand_b_i});

Moreover, the RTL of the line number#49 is similar to the one in line number#72, as shown below:

assign mult_result_d   = $signed({operand_a_i[riscv::XLEN-1] & sign_a, operand_a_i}) *
                                        $signed({operand_b_i[riscv::XLEN-1] & sign_b, operand_b_i});

I have removed these lines form multiplier.sv file.

Thanks!

@zarubaf
Copy link
Contributor

zarubaf commented Aug 1, 2022

Ah thanks for catching that! Indeed that seems to be a duplicate that is not used at all!

@zarubaf zarubaf merged commit 5759203 into openhwgroup:master Aug 1, 2022
zchamski pushed a commit to zchamski/cva6 that referenced this pull request Aug 25, 2022
zchamski pushed a commit to zchamski/cva6 that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants