Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associated PRs in task.yaml #929

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Conversation

eyssartk
Copy link
Contributor

@eyssartk eyssartk commented Jul 4, 2022

This commit provides a new textarea to fill links to PRs used to complete the task.

This commit provide a new textarea to fill links to PRs used to complete the task.
@eyssartk eyssartk requested a review from zarubaf as a code owner July 4, 2022 16:39
@DBees
Copy link
Contributor

DBees commented Jul 4, 2022

@eyssartk As I understand, the intent of this "associated PR template change" is to ask the user to paste a link to a pull request into the task issue.
No problem with this intent but I'm not 100% sure it is what we want.

Note, there is already a method to create a link to a pull request (as discussed on mattermost CVA6 channel): "You can also go into the issue and link a pull request from there.To link it this way, you have to click the gear icon next to "Development" and edit the "link to pull request"." The advantage of the gear icon method is, I think, that you can then display linked pull requests on the project board. So, I think we would want users to use this method rather than simply pasting the URL into the issue.

(As far as I can see however, the gear icon method is only available after the issue is created which isn't ideal. )

I'm reluctant to experiment on these repos, but if you have some issues to link to PRs, you could try out the gear icon method and validate that is what we want. It may be the case you want BOTH to paste the URL, AND to link using the gear icon. I'm not sure.

@eyssartk
Copy link
Contributor Author

eyssartk commented Jul 4, 2022

@DBees I tried to reproduce the "link to a pull request" as discussed in the Mattermost but It seems access rights are different because I could not link a PR (no gear next to development) in CVA6 repo nor CVA6-SDK. Even after issue creation.

Also it seems that this linked PR produce a dependancy: closing a PR will close the task. Is this really what we want ? Surely a task can be fulfilled in multiple PRs. Can we link an issue to multiple PRs ?

@DBees
Copy link
Contributor

DBees commented Jul 4, 2022

Ok, to record what we found/discussed:

  • With triage access as you (@eyssartk ) have, you still don't see the development gear icon for PR and Issues
  • To be confirmed, but in any case CVA6 team doesn't want to automatically close issues linked from a PR
  • Therefore, this pull request to adjust the Issue template with an informative link to PRs is appropriate.

@JeanRochCoulon JeanRochCoulon merged commit 56ccf80 into openhwgroup:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants